From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>,
Alexander Graf <agraf@suse.de>,
C Fontana <claudio.fontana@linaro.org>,
Dirk Mueller <dmueller@suse.de>,
Laurent Desnogues <laurent.desnogues@gmail.com>,
kvmarm@lists.cs.columbia.edu, Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v2 11/12] target-arm: A64: add support for 'test and branch' imm
Date: Wed, 4 Dec 2013 19:33:28 +0000 [thread overview]
Message-ID: <1386185609-25505-12-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1386185609-25505-1-git-send-email-peter.maydell@linaro.org>
From: Alexander Graf <agraf@suse.de>
This patch adds emulation for the test and branch insns,
TBZ and TBNZ.
Signed-off-by: Alexander Graf <agraf@suse.de>
[claudio:
adapted for new decoder
always compare with 0
remove a TCG temporary
]
Signed-off-by: Claudio Fontana <claudio.fontana@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target-arm/translate-a64.c | 27 +++++++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
index afad874..b79672b 100644
--- a/target-arm/translate-a64.c
+++ b/target-arm/translate-a64.c
@@ -215,10 +215,33 @@ static void disas_comp_b_imm(DisasContext *s, uint32_t insn)
unsupported_encoding(s, insn);
}
-/* Test & branch (immediate) */
+/* C3.2.5 Test & branch (immediate)
+ * 31 30 25 24 23 19 18 5 4 0
+ * +----+-------------+----+-------+-------------+------+
+ * | b5 | 0 1 1 0 1 1 | op | b40 | imm14 | Rt |
+ * +----+-------------+----+-------+-------------+------+
+ */
static void disas_test_b_imm(DisasContext *s, uint32_t insn)
{
- unsupported_encoding(s, insn);
+ unsigned int bit_pos, op, rt;
+ uint64_t addr;
+ int label_match;
+ TCGv_i64 tcg_cmp;
+
+ bit_pos = (extract32(insn, 31, 1) << 5) | extract32(insn, 19, 5);
+ op = extract32(insn, 24, 1); /* 0: TBZ; 1: TBNZ */
+ addr = s->pc + sextract32(insn, 5, 14) * 4 - 4;
+ rt = extract32(insn, 0, 5);
+
+ tcg_cmp = tcg_temp_new_i64();
+ tcg_gen_andi_i64(tcg_cmp, cpu_reg(s, rt), (1ULL << bit_pos));
+ label_match = gen_new_label();
+ tcg_gen_brcondi_i64(op ? TCG_COND_NE : TCG_COND_EQ,
+ tcg_cmp, 0, label_match);
+ tcg_temp_free_i64(tcg_cmp);
+ gen_goto_tb(s, 0, s->pc);
+ gen_set_label(label_match);
+ gen_goto_tb(s, 1, addr);
}
/* C3.2.2 / C5.6.19 Conditional branch (immediate)
--
1.7.9.5
next prev parent reply other threads:[~2013-12-04 19:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 19:33 [Qemu-devel] [PATCH v2 00/12] target-arm: A64 decoder, foundation plus branches Peter Maydell
2013-12-04 19:33 ` [Qemu-devel] [PATCH v2 01/12] target-arm: Split A64 from A32/T32 gen_intermediate_code_internal() Peter Maydell
2013-12-04 19:33 ` [Qemu-devel] [PATCH v2 02/12] target-arm: A64: add set_pc cpu method Peter Maydell
2013-12-04 19:33 ` [Qemu-devel] [PATCH v2 03/12] target-arm: A64: provide functions for accessing FPCR and FPSR Peter Maydell
2013-12-04 19:33 ` [Qemu-devel] [PATCH v2 04/12] target-arm: Support fp registers in gdb stub Peter Maydell
2013-12-04 19:33 ` [Qemu-devel] [PATCH v2 05/12] target-arm: A64: add stubs for a64 specific helpers Peter Maydell
2013-12-04 19:33 ` [Qemu-devel] [PATCH v2 06/12] target-arm: A64: provide skeleton for a64 insn decoding Peter Maydell
2013-12-04 19:33 ` [Qemu-devel] [PATCH v2 07/12] target-arm: A64: expand decoding skeleton for system instructions Peter Maydell
2013-12-04 19:33 ` [Qemu-devel] [PATCH v2 08/12] target-arm: A64: add support for B and BL insns Peter Maydell
2013-12-04 21:55 ` Richard Henderson
2013-12-04 22:14 ` Peter Maydell
2013-12-04 22:29 ` Richard Henderson
2013-12-04 22:43 ` Peter Maydell
2013-12-04 19:33 ` [Qemu-devel] [PATCH v2 09/12] target-arm: A64: add support for BR, BLR and RET insns Peter Maydell
2013-12-04 19:33 ` [Qemu-devel] [PATCH v2 10/12] target-arm: A64: add support for conditional branches Peter Maydell
2013-12-04 21:55 ` Richard Henderson
2013-12-04 19:33 ` Peter Maydell [this message]
2013-12-04 21:56 ` [Qemu-devel] [PATCH v2 11/12] target-arm: A64: add support for 'test and branch' imm Richard Henderson
2013-12-04 19:33 ` [Qemu-devel] [PATCH v2 12/12] target-arm: A64: add support for compare and branch imm Peter Maydell
2013-12-04 21:59 ` Richard Henderson
2013-12-04 22:19 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386185609-25505-12-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=agraf@suse.de \
--cc=claudio.fontana@linaro.org \
--cc=dmueller@suse.de \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=laurent.desnogues@gmail.com \
--cc=matz@suse.de \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).