From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoNcT-0001cp-I0 for qemu-devel@nongnu.org; Wed, 04 Dec 2013 20:21:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoNc7-0001jP-CR for qemu-devel@nongnu.org; Wed, 04 Dec 2013 20:20:45 -0500 Received: from e7.ny.us.ibm.com ([32.97.182.137]:59265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoNc7-0001jJ-9e for qemu-devel@nongnu.org; Wed, 04 Dec 2013 20:20:23 -0500 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Dec 2013 20:20:17 -0500 From: Michael Roth Date: Wed, 4 Dec 2013 19:19:50 -0600 Message-Id: <1386206394-21092-11-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1386206394-21092-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1386206394-21092-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 10/14] pci: allow 0 address for PCI IO regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aik@ozlabs.ru, agraf@suse.de, ncmike@ncultra.org, paulus@samba.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, qemu-ppc@nongnu.org Some kernels program a 0 address for io regions. PCI 3.0 spec sectio 6.2.5.1 doesn't seem to disallow this. Signed-off-by: Michael Roth --- hw/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index f15bbb0..fe5729c 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1030,7 +1030,7 @@ static pcibus_t pci_bar_address(PCIDevice *d, /* Check if 32 bit BAR wraps around explicitly. * TODO: make priorities correct and remove this work around. */ - if (last_addr <= new_addr || new_addr == 0 || last_addr >= UINT32_MAX) { + if (last_addr <= new_addr || last_addr >= UINT32_MAX) { return PCI_BAR_UNMAPPED; } return new_addr; -- 1.7.9.5