Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] Adds the ability to use the command key in the guest operating system.

[Programmingkid <programmingkidx@gmail.com>]

On Aug 14, 2013, at 4:58 PM, Alexander Graf wrote:

> 
> On 14.08.2013, at 22:52, Peter Maydell wrote:
> 
>> On 14 August 2013 21:44, Anthony Liguori <anthony@codemonkey.ws> wrote:
>>> I'm confident there's a way to get hardware keycodes on OS X.  There
>>> is on every other UI platform that I know of.  That's the best way to
>>> solve this.

I know you want to use hardware keycodes, but here are (IMHO) the reasons why we should stick with the PC/XT layout:
1) Simple - only one keyboard layout to deal with.
2) Compatible - This layout works with operating systems from MS-DOS 1.0 to Ubuntu Linux 12. 
3) Less work - no major code changes.
4) Good enough - does work with Mac OS X. 
5) Would Mac keyboard keycodes work with Windows, AIX, Solaris, and OS/2? Doubt it. Guess which keyboard layout would work.

>> 
>> Sure, but that doesn't answer the fundamental question of "when
>> should the OS's window/menu accelerator operate the OS menu and
>> when should it be passed to the guest as a raw key". However you
>> get the keycodes you still have that choice.
> 
> The normal rule of thumb IIRC is when mouse grab is active, everything goes into the guest.

That is a good idea. I am thinking of eliminating the -command-key option and just doing the above suggestion. 

Anybody else have their own idea for solving the command key issue?