From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp3DV-0005S3-Ob for qemu-devel@nongnu.org; Fri, 06 Dec 2013 16:45:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vp3DL-0007j4-EG for qemu-devel@nongnu.org; Fri, 06 Dec 2013 16:45:45 -0500 Received: from mail-qe0-x22f.google.com ([2607:f8b0:400d:c02::22f]:34787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp3DL-0007iz-9q for qemu-devel@nongnu.org; Fri, 06 Dec 2013 16:45:35 -0500 Received: by mail-qe0-f47.google.com with SMTP id t7so1004729qeb.20 for ; Fri, 06 Dec 2013 13:45:34 -0800 (PST) Received: from pebble.com ([202.180.67.114]) by mx.google.com with ESMTPSA id x10sm178438865qas.5.2013.12.06.13.45.32 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Dec 2013 13:45:34 -0800 (PST) Sender: Richard Henderson From: Richard Henderson Date: Sat, 7 Dec 2013 10:44:52 +1300 Message-Id: <1386366292-5340-2-git-send-email-rth@twiddle.net> In-Reply-To: <1386366292-5340-1-git-send-email-rth@twiddle.net> References: <1386366292-5340-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH 2/2] cputlb: Tidy memset of arrays List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Don't duplicate the array length computation in the memset when plain sizeof can produce the correct results. Signed-off-by: Richard Henderson --- cputlb.c | 2 +- translate-all.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/cputlb.c b/cputlb.c index d2da404..9270055 100644 --- a/cputlb.c +++ b/cputlb.c @@ -57,7 +57,7 @@ void tlb_flush(CPUArchState *env, int flush_global) cpu->current_tb = NULL; memset(env->tlb_table, -1, sizeof(env->tlb_table)); - memset(env->tb_jmp_cache, 0, TB_JMP_CACHE_SIZE * sizeof (void *)); + memset(env->tb_jmp_cache, 0, sizeof(env->tb_jmp_cache)); env->tlb_flush_addr = -1; env->tlb_flush_mask = 0; diff --git a/translate-all.c b/translate-all.c index aeda54d..66755b1 100644 --- a/translate-all.c +++ b/translate-all.c @@ -699,11 +699,10 @@ void tb_flush(CPUArchState *env1) CPU_FOREACH(cpu) { CPUArchState *env = cpu->env_ptr; - memset(env->tb_jmp_cache, 0, TB_JMP_CACHE_SIZE * sizeof(void *)); + memset(env->tb_jmp_cache, 0, sizeof(env->tb_jmp_cache)); } - memset(tcg_ctx.tb_ctx.tb_phys_hash, 0, - CODE_GEN_PHYS_HASH_SIZE * sizeof(void *)); + memset(tcg_ctx.tb_ctx.tb_phys_hash, 0, sizeof(tcg_ctx.tb_ctx.tb_phys_hash)); page_flush_tb(); tcg_ctx.code_gen_ptr = tcg_ctx.code_gen_buffer; -- 1.8.3.1