From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35398)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1Vp40I-00051H-Vr
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 17:36:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1Vp40C-0006bx-Rk
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 17:36:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38234)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1Vp40C-0006br-It
	for qemu-devel@nongnu.org; Fri, 06 Dec 2013 17:36:04 -0500
Message-ID: <1386369360.25738.523.camel@ul30vt.home>
From: Alex Williamson <alex.williamson@redhat.com>
Date: Fri, 06 Dec 2013 15:36:00 -0700
In-Reply-To: <52A24A6A.6000809@redhat.com>
References: <20131206204715.16731.12627.stgit@bling.home>
	<20131206204842.16731.29998.stgit@bling.home>
	<52A24A6A.6000809@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 4/5] vfio-pci: Add debug config options to
 disable MSI/X KVM support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@amazon.com, kvm@vger.kernel.org

On Fri, 2013-12-06 at 23:06 +0100, Paolo Bonzini wrote:
> Il 06/12/2013 21:48, Alex Williamson ha scritto:
> >  /* Extra debugging, trap acceleration paths for more logging */
> >  #define VFIO_ALLOW_MMAP 1
> >  #define VFIO_ALLOW_KVM_INTX 1
> > +#define VFIO_ALLOW_KVM_MSI 1
> > +#define VFIO_ALLOW_KVM_MSIX 1
> 
> Why not make these device properties instead?

Honestly, I don't think they're that useful to the average or even to
the advanced user.  Each of these disables an acceleration/bypass path
and gives more logging output when debug is enabled.  Otherwise we don't
get debugging to see when mmap'd BARs are accessed and we can't tell
when interrupts happen relative to other accesses.  For instance it was
pretty obvious to find the Nvidia MSI ACK when seeing a config space
write immediately following an MSI injection.  Without debugging
enabled, these just slow things down and I don't know of any cases where
a device behaves better with these features disabled.  Thanks,

Alex