* [Qemu-devel] [PATCH v3] fix -boot strict regressed in commit 6ef4716
@ 2013-12-09 11:53 Amos Kong
2013-12-09 12:10 ` Markus Armbruster
2013-12-09 12:16 ` Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: Amos Kong @ 2013-12-09 11:53 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, mjt, armbru, anthony
Commit 6ef4716 cleaned up parsing of -boot option argument, but
accidentally dropped parameter strict. It should have been updated
exactly like parameter menu. Do that.
Signed-off-by: Amos Kong <akong@redhat.com>
---
v2: remove bios.bin change, I just used it for testing (mjt)
v3: merge two patches together, correct the commitlog (markus)
---
vl.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/vl.c b/vl.c
index b0399de..ae6d0c6 100644
--- a/vl.c
+++ b/vl.c
@@ -461,7 +461,7 @@ static QemuOptsList qemu_boot_opts = {
.type = QEMU_OPT_STRING,
}, {
.name = "strict",
- .type = QEMU_OPT_STRING,
+ .type = QEMU_OPT_BOOL,
},
{ /*End of list */ }
},
@@ -4074,6 +4074,7 @@ int main(int argc, char **argv, char **envp)
}
boot_menu = qemu_opt_get_bool(opts, "menu", boot_menu);
+ boot_strict = qemu_opt_get_bool(opts, "strict", false);
}
if (!kernel_cmdline) {
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v3] fix -boot strict regressed in commit 6ef4716
2013-12-09 11:53 [Qemu-devel] [PATCH v3] fix -boot strict regressed in commit 6ef4716 Amos Kong
@ 2013-12-09 12:10 ` Markus Armbruster
2013-12-09 12:16 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2013-12-09 12:10 UTC (permalink / raw)
To: Amos Kong; +Cc: pbonzini, mjt, qemu-devel, anthony
Amos Kong <akong@redhat.com> writes:
> Commit 6ef4716 cleaned up parsing of -boot option argument, but
> accidentally dropped parameter strict. It should have been updated
> exactly like parameter menu. Do that.
>
> Signed-off-by: Amos Kong <akong@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v3] fix -boot strict regressed in commit 6ef4716
2013-12-09 11:53 [Qemu-devel] [PATCH v3] fix -boot strict regressed in commit 6ef4716 Amos Kong
2013-12-09 12:10 ` Markus Armbruster
@ 2013-12-09 12:16 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2013-12-09 12:16 UTC (permalink / raw)
To: Amos Kong; +Cc: pbonzini, qemu-devel, anthony, armbru
09.12.2013 15:53, Amos Kong wrote:
> Commit 6ef4716 cleaned up parsing of -boot option argument, but
> accidentally dropped parameter strict. It should have been updated
> exactly like parameter menu. Do that.
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> v2: remove bios.bin change, I just used it for testing (mjt)
> v3: merge two patches together, correct the commitlog (markus)
Picked the new version up on trivial-patches, thank you!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-09 12:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-09 11:53 [Qemu-devel] [PATCH v3] fix -boot strict regressed in commit 6ef4716 Amos Kong
2013-12-09 12:10 ` Markus Armbruster
2013-12-09 12:16 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).