From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq1Ts-0003UC-UM for qemu-devel@nongnu.org; Mon, 09 Dec 2013 09:06:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vq1To-00027O-Fn for qemu-devel@nongnu.org; Mon, 09 Dec 2013 09:06:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq1To-00027D-7s for qemu-devel@nongnu.org; Mon, 09 Dec 2013 09:06:36 -0500 From: Gerd Hoffmann Date: Mon, 9 Dec 2013 15:06:13 +0100 Message-Id: <1386597974-26506-4-git-send-email-kraxel@redhat.com> In-Reply-To: <1386597974-26506-1-git-send-email-kraxel@redhat.com> References: <1386597974-26506-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 3/4] adlib: fix patching of port I/O addresses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , "Vassili Karpov (malc)" , Gerd Hoffmann From: Paolo Bonzini Commit 2b21fb5 (adlib: sort offsets in portio registration, 2013-08-14) fixed the offsets in adlib_portio_list, but forgot the matching indices in adlib_realizefn. Reported at http://virtuallyfun.superglobalmegacorp.com/?p=3D3616 by "neozeed". Signed-off-by: Paolo Bonzini Reviewed-by: Herv=C3=A9 Poussineau Signed-off-by: Gerd Hoffmann --- hw/audio/adlib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index bd8e9d9..e88d2dd 100644 --- a/hw/audio/adlib.c +++ b/hw/audio/adlib.c @@ -347,8 +347,8 @@ static void adlib_realizefn (DeviceState *dev, Error = **errp) s->samples =3D AUD_get_buffer_size_out (s->voice) >> SHIFT; s->mixbuf =3D g_malloc0 (s->samples << SHIFT); =20 - adlib_portio_list[1].offset =3D s->port; - adlib_portio_list[2].offset =3D s->port + 8; + adlib_portio_list[0].offset =3D s->port; + adlib_portio_list[1].offset =3D s->port + 8; portio_list_init (port_list, OBJECT(s), adlib_portio_list, s, "adlib= "); portio_list_add (port_list, isa_address_space_io(&s->parent_obj), 0)= ; } --=20 1.8.3.1