qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: cornelia.huck@de.ibm.com, afaerber@suse.de, mst@redhat.com
Subject: [Qemu-devel] [PULL 20/30] virtio-scsi: QOM realize preparations
Date: Mon,  9 Dec 2013 21:48:22 +0100	[thread overview]
Message-ID: <1386622112-27257-21-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1386622112-27257-1-git-send-email-pbonzini@redhat.com>

From: Andreas Färber <afaerber@suse.de>

Rename qdev -> dev since that's what realize's argument is called by
convention. No need to keep more "qdev" around than necessary.

Avoid duplicate VIRTIO_DEVICE() cast.

Signed-off-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/scsi/virtio-scsi.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index 83344ea..a5b957d 100644
--- a/hw/scsi/virtio-scsi.c
+++ b/hw/scsi/virtio-scsi.c
@@ -594,7 +594,7 @@ int virtio_scsi_common_init(VirtIOSCSICommon *s)
     VirtIODevice *vdev = VIRTIO_DEVICE(s);
     int i;
 
-    virtio_init(VIRTIO_DEVICE(s), "virtio-scsi", VIRTIO_ID_SCSI,
+    virtio_init(vdev, "virtio-scsi", VIRTIO_ID_SCSI,
                 sizeof(VirtIOSCSIConfig));
 
     s->cmd_vqs = g_malloc0(s->conf.num_queues * sizeof(VirtQueue *));
@@ -615,9 +615,9 @@ int virtio_scsi_common_init(VirtIOSCSICommon *s)
 
 static int virtio_scsi_device_init(VirtIODevice *vdev)
 {
-    DeviceState *qdev = DEVICE(vdev);
-    VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(vdev);
-    VirtIOSCSI *s = VIRTIO_SCSI(vdev);
+    DeviceState *dev = DEVICE(vdev);
+    VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(dev);
+    VirtIOSCSI *s = VIRTIO_SCSI(dev);
     static int virtio_scsi_id;
     Error *err = NULL;
     int ret;
@@ -627,10 +627,10 @@ static int virtio_scsi_device_init(VirtIODevice *vdev)
         return ret;
     }
 
-    scsi_bus_new(&s->bus, sizeof(s->bus), qdev,
+    scsi_bus_new(&s->bus, sizeof(s->bus), dev,
                  &virtio_scsi_scsi_info, vdev->bus_name);
 
-    if (!qdev->hotplugged) {
+    if (!dev->hotplugged) {
         scsi_bus_legacy_handle_cmdline(&s->bus, &err);
         if (err != NULL) {
             error_free(err);
@@ -638,7 +638,7 @@ static int virtio_scsi_device_init(VirtIODevice *vdev)
         }
     }
 
-    register_savevm(qdev, "virtio-scsi", virtio_scsi_id++, 1,
+    register_savevm(dev, "virtio-scsi", virtio_scsi_id++, 1,
                     virtio_scsi_save, virtio_scsi_load, s);
 
     return 0;
-- 
1.8.4.2

  parent reply	other threads:[~2013-12-09 20:49 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09 20:48 [Qemu-devel] [PULL 00/30] virtio conversion to realize and hotplug/unplug fixes Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 01/30] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 02/30] virtio-bus: remove vdev field Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 03/30] virtio-ccw: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 04/30] virtio-pci: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 05/30] virtio-bus: cleanup plug/unplug interface Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 06/30] virtio-blk: switch exit callback to VirtioDeviceClass Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 07/30] virtio-serial: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 08/30] virtio-net: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 09/30] virtio-scsi: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 10/30] virtio-balloon: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 11/30] virtio-rng: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 12/30] virtio-pci: add device_unplugged callback Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 13/30] virtio-blk-dataplane: Improve error reporting Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 14/30] virtio-9p: QOM realize preparations Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 15/30] virtio-blk: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 16/30] virtio-serial: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 17/30] virtio-net: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 18/30] virtio-balloon: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 19/30] virtio-rng: " Paolo Bonzini
2013-12-09 20:48 ` Paolo Bonzini [this message]
2013-12-09 20:48 ` [Qemu-devel] [PULL 21/30] virtio: Start converting VirtioDevice to QOM realize Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 22/30] virtio-9p: Convert " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 23/30] virtio-blk: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 24/30] virtio-serial: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 25/30] virtio-net: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 26/30] virtio-balloon: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 27/30] virtio-rng: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 28/30] virtio-scsi: " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 29/30] virtio: Complete converting VirtioDevice " Paolo Bonzini
2013-12-09 20:48 ` [Qemu-devel] [PULL 30/30] virtio: Convert exit to unrealize Paolo Bonzini
2013-12-19 15:25   ` Stefan Hajnoczi
2013-12-19 15:32     ` Paolo Bonzini
2013-12-11  0:12 ` [Qemu-devel] [PULL 00/30] virtio conversion to realize and hotplug/unplug fixes Anthony Liguori
2013-12-11  7:45   ` Paolo Bonzini
2013-12-13 15:50     ` Paolo Bonzini
2013-12-13 16:37       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386622112-27257-21-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=cornelia.huck@de.ibm.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).