From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43098)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VqOEk-0004xr-Dr
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 09:24:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VqOEb-0002ez-2h
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 09:24:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59259)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VqOEa-0002eZ-R9
	for qemu-devel@nongnu.org; Tue, 10 Dec 2013 09:24:25 -0500
Message-ID: <1386685458.15686.5.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 10 Dec 2013 15:24:18 +0100
In-Reply-To: <52A6A9E2.9060705@weilnetz.de>
References: <1386648358-25892-1-git-send-email-airlied@gmail.com>
	<52A6A9E2.9060705@weilnetz.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] sdl2 + virtio-gpu repost
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Dave Airlie <airlied@gmail.com>, qemu-devel@nongnu.org

On Di, 2013-12-10 at 06:42 +0100, Stefan Weil wrote:
> Am 10.12.2013 05:05, schrieb Dave Airlie:
> > Hi,
> >
> > This is a repost of the latest SDL2 UI layer along with virtio-gpu,
> >
> > I've merged the SDL2 base and multi-head patches into one, and I've split
> > out the display notifiers stuff and the sdl2 demo hack.
> >
> > The virtio-gpu/vga wrapping is still unresolved, I've failed to find a cleaner
> > way yet, hopefully Gerd will advise further, but having 4 virtio-gpu- objects
> > we getting ugly fast. I've also included a doc on the basic queues used in the
> > virtio-gpu and what commands are sent on them.
> >
> > I'd really like to get the sdl2 base patch merged at least,
> >
> > Dave.
> 
> I did not review all patches in the series, but stopped at the first one
> which had style issues.
> 
> Please check your patches using scripts/checkpatch.pl.

To be fair most of this comes from ui/sdl.c not conforming to qemu code
style, because the code predates the current qemu code style.

Nevertheless it is a good idea to hook up scripts/checkpatch.pl in the
git pre-commit.

cheers,
  Gerd