From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqQg5-0005BN-8l for qemu-devel@nongnu.org; Tue, 10 Dec 2013 12:01:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqQfv-0001BN-TD for qemu-devel@nongnu.org; Tue, 10 Dec 2013 12:00:57 -0500 Received: from mail-qe0-x235.google.com ([2607:f8b0:400d:c02::235]:44962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqQfv-0001BJ-F4 for qemu-devel@nongnu.org; Tue, 10 Dec 2013 12:00:47 -0500 Received: by mail-qe0-f53.google.com with SMTP id nc12so4235113qeb.26 for ; Tue, 10 Dec 2013 09:00:46 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 10 Dec 2013 18:00:25 +0100 Message-Id: <1386694828-19786-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1386694828-19786-1-git-send-email-pbonzini@redhat.com> References: <1386694828-19786-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 2/5] qom: fix leak for objects created with -object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: imammedo@redhat.com, akong@redhat.com, armbru@redhat.com, lcapitulino@redhat.com The object must be unref-ed when its variable goes out of scope. Signed-off-by: Paolo Bonzini --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 8d5d874..6917fd1 100644 --- a/vl.c +++ b/vl.c @@ -2807,12 +2807,13 @@ static int object_create(QemuOpts *opts, void *opaque) obj = object_new(type); if (qemu_opt_foreach(opts, object_set_property, obj, 1) < 0) { + object_unref(obj); return -1; } object_property_add_child(container_get(object_get_root(), "/objects"), id, obj, NULL); - + object_unref(obj); return 0; } -- 1.8.4.2