qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com,
	lcapitulino@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH V4 8/9] qapi: convert BlockdevOptions to use enum discriminator
Date: Wed, 11 Dec 2013 13:48:31 +0800	[thread overview]
Message-ID: <1386740912-1655-9-git-send-email-xiawenc@linux.vnet.ibm.com> (raw)
In-Reply-To: <1386740912-1655-1-git-send-email-xiawenc@linux.vnet.ibm.com>

After this patch, hidden enum type BlockdevOptionsKind will not
be generated, and other API can use enum BlockdevDriver.

Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 qapi-schema.json |   14 +++++++++++++-
 1 files changed, 13 insertions(+), 1 deletions(-)

diff --git a/qapi-schema.json b/qapi-schema.json
index d6f8615..61249db 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -4046,6 +4046,18 @@
             '*no-flush': 'bool' } }
 
 ##
+# @BlockdevDriver
+#
+# Drivers that are supported in block device operations.
+#
+# Since: 2.0
+##
+{ 'enum': 'BlockdevDriver',
+  'data': [ 'file', 'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat', 'bochs',
+            'cloop', 'cow', 'dmg', 'parallels', 'qcow', 'qcow2', 'qed', 'raw',
+            'vdi', 'vhdx', 'vmdk', 'vpc' ] }
+
+##
 # @BlockdevOptionsBase
 #
 # Options that are available for all block devices, independent of the block
@@ -4068,7 +4080,7 @@
 # Since: 1.7
 ##
 { 'type': 'BlockdevOptionsBase',
-  'data': { 'driver': 'str',
+  'data': { 'driver': 'BlockdevDriver',
             '*id': 'str',
             '*discard': 'BlockdevDiscardOptions',
             '*cache': 'BlockdevCacheOptions',
-- 
1.7.1

  parent reply	other threads:[~2013-12-11  5:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11  5:48 [Qemu-devel] [PATCH V4 0/9] qapi script: support enum as discriminator and better enum name Wenchao Xia
2013-12-11  5:48 ` [Qemu-devel] [PATCH V4 1/9] qapi script: remember enum values Wenchao Xia
2013-12-11  5:48 ` [Qemu-devel] [PATCH V4 2/9] qapi script: add check for duplicated key Wenchao Xia
2013-12-11  5:48 ` [Qemu-devel] [PATCH V4 3/9] qapi script: check correctness of discriminator values in union Wenchao Xia
2013-12-11  5:48 ` [Qemu-devel] [PATCH V4 4/9] qapi script: code move for generate_enum_name() Wenchao Xia
2013-12-11  5:48 ` [Qemu-devel] [PATCH V4 5/9] qapi script: use same function to generate enum string Wenchao Xia
2013-12-12  4:26   ` Eric Blake
2013-12-11  5:48 ` [Qemu-devel] [PATCH V4 6/9] qapi script: support pre-defined enum type as discriminator in union Wenchao Xia
2013-12-13 14:10   ` Eric Blake
2013-12-11  5:48 ` [Qemu-devel] [PATCH V4 7/9] tests: add cases for inherited struct and union with discriminator Wenchao Xia
2013-12-13 23:47   ` Eric Blake
2013-12-11  5:48 ` Wenchao Xia [this message]
2013-12-13 23:50   ` [Qemu-devel] [PATCH V4 8/9] qapi: convert BlockdevOptions to use enum discriminator Eric Blake
2013-12-16  2:41     ` Wenchao Xia
2013-12-16 21:26       ` Luiz Capitulino
2013-12-11  5:48 ` [Qemu-devel] [PATCH V4 9/9] qapi script: do not add "_" for every capitalized char in enum Wenchao Xia
2013-12-13 23:50   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386740912-1655-9-git-send-email-xiawenc@linux.vnet.ibm.com \
    --to=xiawenc@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).