From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqim8-0004Fa-3R for qemu-devel@nongnu.org; Wed, 11 Dec 2013 07:20:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vqilz-0007RG-Me for qemu-devel@nongnu.org; Wed, 11 Dec 2013 07:20:24 -0500 Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:50895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqilz-0007RB-Hd for qemu-devel@nongnu.org; Wed, 11 Dec 2013 07:20:15 -0500 Received: by mail-qc0-f180.google.com with SMTP id w7so5011167qcr.11 for ; Wed, 11 Dec 2013 04:20:15 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 11 Dec 2013 13:19:16 +0100 Message-Id: <1386764361-15260-10-git-send-email-pbonzini@redhat.com> In-Reply-To: <1386764361-15260-1-git-send-email-pbonzini@redhat.com> References: <1386764361-15260-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [RFC PATCH 09/14] qom: fix leak for objects created with -object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: imammedo@redhat.com, gaowanlong@cn.fujitsu.com, stefanha@redhat.com The object must be unref-ed when its variable goes out of scope. Signed-off-by: Paolo Bonzini --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 68ba565..086a062 100644 --- a/vl.c +++ b/vl.c @@ -2717,12 +2717,13 @@ static int object_create(QemuOpts *opts, void *opaque) obj = object_new(type); if (qemu_opt_foreach(opts, object_set_property, obj, 1) < 0) { + object_unref(obj); return -1; } object_property_add_child(container_get(object_get_root(), "/objects"), id, obj, NULL); - + object_unref(obj); return 0; } -- 1.8.4.2