qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, rjones@redhat.com, armbru@redhat.com,
	imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v7 05/10] stream: Use bdrv_drop_intermediate and drop close_unused_images
Date: Thu, 12 Dec 2013 16:23:41 +0800	[thread overview]
Message-ID: <1386836626-6436-6-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1386836626-6436-1-git-send-email-famz@redhat.com>

This reuses the new bdrv_drop_intermediate.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block/stream.c | 28 +---------------------------
 1 file changed, 1 insertion(+), 27 deletions(-)

diff --git a/block/stream.c b/block/stream.c
index 46bec7d..9cdcf0e 100644
--- a/block/stream.c
+++ b/block/stream.c
@@ -51,32 +51,6 @@ static int coroutine_fn stream_populate(BlockDriverState *bs,
     return bdrv_co_copy_on_readv(bs, sector_num, nb_sectors, &qiov);
 }
 
-static void close_unused_images(BlockDriverState *top, BlockDriverState *base,
-                                const char *base_id)
-{
-    BlockDriverState *intermediate;
-    intermediate = top->backing_hd;
-
-    /* Must assign before bdrv_delete() to prevent traversing dangling pointer
-     * while we delete backing image instances.
-     */
-    top->backing_hd = base;
-
-    while (intermediate) {
-        BlockDriverState *unused;
-
-        /* reached base */
-        if (intermediate == base) {
-            break;
-        }
-
-        unused = intermediate;
-        intermediate = intermediate->backing_hd;
-        unused->backing_hd = NULL;
-        bdrv_unref(unused);
-    }
-}
-
 static void coroutine_fn stream_run(void *opaque)
 {
     StreamBlockJob *s = opaque;
@@ -190,7 +164,7 @@ wait:
             }
         }
         ret = bdrv_change_backing_file(bs, base_id, base_fmt);
-        close_unused_images(bs, base, base_id);
+        bdrv_drop_intermediate(bs, bs->backing_hd, base);
     }
 
     qemu_vfree(buf);
-- 
1.8.5.1

  parent reply	other threads:[~2013-12-12  8:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12  8:23 [Qemu-devel] [PATCH v7 00/10] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Fam Zheng
2013-12-12  8:23 ` [Qemu-devel] [PATCH v7 01/10] qapi: Add BlockOperationType enum Fam Zheng
2013-12-12 12:21   ` Kevin Wolf
2013-12-12 12:32     ` Fam Zheng
2013-12-12 12:49   ` Markus Armbruster
2013-12-12 12:53     ` Fam Zheng
2013-12-12  8:23 ` [Qemu-devel] [PATCH v7 02/10] block: Introduce op_blockers to BlockDriverState Fam Zheng
2013-12-12 12:50   ` Markus Armbruster
2013-12-12  8:23 ` [Qemu-devel] [PATCH v7 03/10] block: Parse "backing" option to reference existing BDS Fam Zheng
2013-12-12 12:52   ` Markus Armbruster
2013-12-12  8:23 ` [Qemu-devel] [PATCH v7 04/10] block: support dropping active in bdrv_drop_intermediate Fam Zheng
2013-12-12 13:24   ` Kevin Wolf
2013-12-13  3:30     ` Fam Zheng
2013-12-12  8:23 ` Fam Zheng [this message]
2013-12-12  8:23 ` [Qemu-devel] [PATCH v7 06/10] block: Replace in_use with operation blocker Fam Zheng
2013-12-12 13:46   ` Markus Armbruster
2013-12-13  3:04     ` Fam Zheng
2013-12-12  8:23 ` [Qemu-devel] [PATCH v7 07/10] block: Pass error in bdrv_snapshot_create Fam Zheng
2013-12-12 13:52   ` Markus Armbruster
2013-12-12  8:23 ` [Qemu-devel] [PATCH v7 08/10] block: Add checks of blocker in block operations Fam Zheng
2013-12-12 13:56   ` Markus Armbruster
2013-12-13  3:29     ` Fam Zheng
2013-12-12  8:23 ` [Qemu-devel] [PATCH v7 09/10] qmp: add command 'blockdev-backup' Fam Zheng
2013-12-12  8:23 ` [Qemu-devel] [PATCH v7 10/10] block: Allow backup on referenced named BlockDriverState Fam Zheng
2013-12-13  2:40 ` [Qemu-devel] [PATCH v7 00/10] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Ian Main
2013-12-13  3:05   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386836626-6436-6-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=imain@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).