From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr5m1-00076f-Jh for qemu-devel@nongnu.org; Thu, 12 Dec 2013 07:53:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vr5lu-0001Nj-9Y for qemu-devel@nongnu.org; Thu, 12 Dec 2013 07:53:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr5lt-0001NQ-Vd for qemu-devel@nongnu.org; Thu, 12 Dec 2013 07:53:42 -0500 Message-ID: <1386852817.19301.55.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 12 Dec 2013 13:53:37 +0100 In-Reply-To: References: <1386648358-25892-1-git-send-email-airlied@gmail.com> <1386648358-25892-2-git-send-email-airlied@gmail.com> <1386686106.15686.12.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v2.0) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dave Airlie Cc: "qemu-devel@nongnu.org" On Mi, 2013-12-11 at 11:12 +1000, Dave Airlie wrote: > On Wed, Dec 11, 2013 at 12:35 AM, Gerd Hoffmann wrote: > > Hi, > > > >> The biggest changes were in the input handling, where SDL2 has done a major > >> overhaul, and I've had to include a generated translation file to get from > >> SDL2 codes back to qemu compatible ones. I'm still not sure how the keyboard > >> layout code works in qemu, so there may be further work if someone can point > >> me a test case that works with SDL1.2 and doesn't with SDL2. > > > > I've picked it up, cleaned up a bit (more to be done), switched over to > > new input core. Simplified the keyboard mess, the new input support in > > SDL2 allows us to reduce it to a single+simple lookup table. Pushed > > here: > > Oh thanks for that, looks a lot cleaner esp the input handling, let me > know if there > is anything you'd like me to look at. Testing would be nice (but take care a bit, the branch is a moving target, i.e. rebases), other than that nothing for now. I wanna get the input patch series out-of-the-door asap, probably with the sdl2 bits sprinkled in at the correct places so the whole thing is bisectable. > I wasn't sure if we wanted to keep the old text console switching > stuff on console 0 or not, > I see you've ripped it out, I can't say I ever used it anyways. It's pointless if we explicitly bind to a specific console. The switching would change active_console, but you wouldn't see it. cheers, Gerd