From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr6c6-0004GG-15 for qemu-devel@nongnu.org; Thu, 12 Dec 2013 08:47:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vr6bz-0002N4-Ur for qemu-devel@nongnu.org; Thu, 12 Dec 2013 08:47:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr6bz-0002Mx-NK for qemu-devel@nongnu.org; Thu, 12 Dec 2013 08:47:31 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBCDlTOm022132 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 12 Dec 2013 08:47:30 -0500 From: Gerd Hoffmann Date: Thu, 12 Dec 2013 14:47:26 +0100 Message-Id: <1386856046-28929-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH] usb-host: add range checks for usb-host parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index fd320cd..164adf8 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -898,6 +898,19 @@ static int usb_host_initfn(USBDevice *udev) { USBHostDevice *s = USB_HOST_DEVICE(udev); + if (s->match.vendor_id > 0xffff) { + error_report("vendorid out of range"); + return -1; + } + if (s->match.product_id > 0xffff) { + error_report("productid out of range"); + return -1; + } + if (s->match.addr > 127) { + error_report("hostaddr out of range"); + return -1; + } + loglevel = s->loglevel; udev->flags |= (1 << USB_DEV_FLAG_IS_HOST); udev->auto_attach = 0; -- 1.8.3.1