From: Gerd Hoffmann <kraxel@redhat.com>
To: Dave Airlie <airlied@gmail.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] issue with vgabios lfb and virtio vga
Date: Fri, 13 Dec 2013 08:06:00 +0100 [thread overview]
Message-ID: <1386918360.8306.4.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <CAPM=9twPDVHXRA3sQiut4tLrOL+Db2wdgXqVKLL82Jg=AHodPw@mail.gmail.com>
On Fr, 2013-12-13 at 11:58 +1000, Dave Airlie wrote:
> On Thu, Dec 12, 2013 at 6:17 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > On Do, 2013-12-12 at 09:51 +1000, Dave Airlie wrote:
> >> Now the vgabios.c does a check of bar 0 and bar 1 to see if they are
> >> 0xfff1 masked, this protects against the the i/o bar but fails to
> >> protect against the LFB one as PCI BARs don't encode the size just the
> >> base address, and a 4k BAR can be aligned to a larger size.
> >
> >> Any ideas? I seem to remember vgabios.c had a hack in the past for
> >> vmware, but I'm not sure.
> >
> > The fallback to bar #1 *is* the vmware hack ;)
> >
> > Something like the attached patch should do the trick.
> >
> Oh do we generate the VGABIOS from seabios now or are we going to?
master is switched to seavgabios, 1.7 still at the old one.
"git submodule init" will fetch firmware subtrees.
the Makefile in roms/ has targets to build vgabioses.
cheers,
Gerd
prev parent reply other threads:[~2013-12-13 7:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 23:51 [Qemu-devel] issue with vgabios lfb and virtio vga Dave Airlie
2013-12-12 8:17 ` Gerd Hoffmann
2013-12-13 1:58 ` Dave Airlie
2013-12-13 7:06 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386918360.8306.4.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=airlied@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).