From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VrMpU-0004UE-6E
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 02:06:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VrMpO-0005lX-7R
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 02:06:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:27104)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VrMpN-0005lS-VN
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 02:06:26 -0500
Message-ID: <1386918360.8306.4.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 13 Dec 2013 08:06:00 +0100
In-Reply-To: <CAPM=9twPDVHXRA3sQiut4tLrOL+Db2wdgXqVKLL82Jg=AHodPw@mail.gmail.com>
References: <CAPM=9tx+5tpQXPQ7qn5F1mKD0=HbdCM4U1zxzQz6sQGLePW_sQ@mail.gmail.com>
	<1386836240.19301.6.camel@nilsson.home.kraxel.org>
	<CAPM=9twPDVHXRA3sQiut4tLrOL+Db2wdgXqVKLL82Jg=AHodPw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] issue with vgabios lfb and virtio vga
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dave Airlie <airlied@gmail.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Fr, 2013-12-13 at 11:58 +1000, Dave Airlie wrote:
> On Thu, Dec 12, 2013 at 6:17 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > On Do, 2013-12-12 at 09:51 +1000, Dave Airlie wrote:
> >> Now the vgabios.c does a check of bar 0 and bar 1 to see if they are
> >> 0xfff1 masked, this protects against the the i/o bar but fails to
> >> protect against the LFB one as PCI BARs don't encode the size just the
> >> base address, and a 4k BAR can be aligned to a larger size.
> >
> >> Any ideas? I seem to remember vgabios.c had a hack in the past for
> >> vmware, but I'm not sure.
> >
> > The fallback to bar #1 *is* the vmware hack ;)
> >
> > Something like the attached patch should do the trick.
> >
> Oh do we generate the VGABIOS from seabios now or are we going to?

master is switched to seavgabios, 1.7 still at the old one.

"git submodule init" will fetch firmware subtrees.
the Makefile in roms/ has targets to build vgabioses.

cheers,
  Gerd