From: Gerd Hoffmann <kraxel@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking
Date: Fri, 13 Dec 2013 10:57:12 +0100 [thread overview]
Message-ID: <1386928632.8306.14.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <52A8EF33.4020207@redhat.com>
Hi,
> <rant>
> WHY is strtol() such a PAINFUL interface to use correctly? And WHY
> can't qemu copy libvirt's lead of writing a SANE wrapper function, and
> then mandating that the rest of the code base use the sane wrapper
> instead of strtol()?
> </rant>
Turns out there already is one, just /me didn't know.
So, for the record and the mailing list archives:
util/cutil.c provides parse_uint() and parse_uint_full().
The first returns a pointer to the remaining bits to parse, so you can
inspect the suffix (if any). The second errors out in case there is
trailing garbage, simliar to the libvirt wrapper in case you pass in
NULL as end_ptr.
cheers,
Gerd
next prev parent reply other threads:[~2013-12-13 11:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 12:00 [Qemu-devel] [PATCH] inet_listen_opts: add error checking Gerd Hoffmann
2013-12-11 23:03 ` Eric Blake
2013-12-12 12:27 ` Gerd Hoffmann
2013-12-12 15:50 ` Eric Blake
2013-12-13 9:57 ` Gerd Hoffmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-13 9:57 Gerd Hoffmann
2014-05-21 10:53 Gerd Hoffmann
2014-05-21 11:57 ` Markus Armbruster
2014-05-22 3:27 ` Gonglei (Arei)
2014-05-22 5:43 ` Gerd Hoffmann
2014-05-22 6:10 ` Gonglei (Arei)
2014-05-22 5:44 Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386928632.8306.14.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).