From: Vincenzo Maffione <v.maffione@gmail.com>
To: qemu-devel@nongnu.org
Cc: aliguori@amazon.com, marcel.a@redhat.com, jasowang@redhat.com,
Vincenzo Maffione <v.maffione@gmail.com>,
lcapitulino@redhat.com, stefanha@redhat.com, dmitry@daynix.com,
pbonzini@redhat.com, g.lettieri@iet.unipi.it, rizzo@iet.unipi.it
Subject: [Qemu-devel] [PATCH 5/5] net: virtio-net and vmxnet3 can use netmap offloadings
Date: Fri, 13 Dec 2013 13:05:03 +0100 [thread overview]
Message-ID: <1386936303-7697-6-git-send-email-v.maffione@gmail.com> (raw)
In-Reply-To: <1386936303-7697-1-git-send-email-v.maffione@gmail.com>
With this patch we remove the existing checks in the virtio-net
and vmxnet3 frontends that prevents them from using
offloadings with backends different from TAP (e.g. netmap).
Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
---
hw/net/virtio-net.c | 4 ----
hw/net/vmxnet3.c | 4 +---
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index c8ee2fa..8a94539 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -325,10 +325,6 @@ static void peer_test_vnet_hdr(VirtIONet *n)
return;
}
- if (nc->peer->info->type != NET_CLIENT_OPTIONS_KIND_TAP) {
- return;
- }
-
n->has_vnet_hdr = qemu_peer_has_vnet_hdr(nc);
}
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index f00c649..0524684 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -1885,9 +1885,7 @@ static bool vmxnet3_peer_has_vnet_hdr(VMXNET3State *s)
{
NetClientState *nc = qemu_get_queue(s->nic);
- if ((NULL != nc->peer) &&
- (nc->peer->info->type == NET_CLIENT_OPTIONS_KIND_TAP) &&
- qemu_peer_has_vnet_hdr(nc)) {
+ if (qemu_peer_has_vnet_hdr(nc)) {
return true;
}
--
1.8.5.1
next prev parent reply other threads:[~2013-12-13 12:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 12:04 [Qemu-devel] [PATCH 0/5] Add netmap backend offloadings support Vincenzo Maffione
2013-12-13 12:04 ` [Qemu-devel] [PATCH 1/5] net: extend NetClientInfo for offloading manipulations Vincenzo Maffione
2014-01-13 6:58 ` Stefan Hajnoczi
2014-01-13 14:07 ` Vincenzo Maffione
2013-12-13 12:05 ` [Qemu-devel] [PATCH 2/5] net: TAP uses NetClientInfo offloading callbacks Vincenzo Maffione
2013-12-13 12:05 ` [Qemu-devel] [PATCH 3/5] net: virtio-net and vmxnet3 use offloading API Vincenzo Maffione
2013-12-13 12:05 ` [Qemu-devel] [PATCH 4/5] net: add offloadings support to netmap backend Vincenzo Maffione
2014-01-13 7:28 ` Stefan Hajnoczi
2014-01-13 15:11 ` Vincenzo Maffione
2014-01-14 3:46 ` Stefan Hajnoczi
2013-12-13 12:05 ` Vincenzo Maffione [this message]
2014-01-13 7:33 ` [Qemu-devel] [PATCH 0/5] Add netmap backend offloadings support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386936303-7697-6-git-send-email-v.maffione@gmail.com \
--to=v.maffione@gmail.com \
--cc=aliguori@amazon.com \
--cc=dmitry@daynix.com \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=marcel.a@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).