qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PATCH 01/16] spice: flip streaming video mode to off by default
Date: Mon, 16 Dec 2013 10:31:02 +0100	[thread overview]
Message-ID: <1387186277-9573-2-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1387186277-9573-1-git-send-email-kraxel@redhat.com>

Video streaming detection heuristics in spice-server have problems
keeping modern desktop animations (as done by gnome shell) and real
video playback apart.  This leads to jpeg compression artefacts on
your desktop, due to spice using mjpeg to send what it thinks is
a video stream.

Turn off video detection by default to avoid these artifacts.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Alon Levy <alevy@redhat.com>
---
 ui/spice-core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ui/spice-core.c b/ui/spice-core.c
index e4d533d..9fb9544 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -776,6 +776,8 @@ void qemu_spice_init(void)
     if (str) {
         int streaming_video = parse_stream_video(str);
         spice_server_set_streaming_video(spice_server, streaming_video);
+    } else {
+        spice_server_set_streaming_video(spice_server, SPICE_STREAM_VIDEO_OFF);
     }
 
     spice_server_set_agent_mouse
-- 
1.8.3.1

  reply	other threads:[~2013-12-16  9:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16  9:31 [Qemu-devel] [PULL 00/16] spice patch queue Gerd Hoffmann
2013-12-16  9:31 ` Gerd Hoffmann [this message]
2013-12-16  9:31 ` [Qemu-devel] [PATCH 02/16] vscclient: do not add a socket watch if there is not data to send Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 03/16] spice-char: remove unused field Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 04/16] qmp_change_blockdev() remove unused has_format Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 05/16] include: add missing config-host.h include Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 06/16] char: add qemu_chr_fe_event() Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 07/16] spice-char: implement chardev port event Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 08/16] Split nbd block client code Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 09/16] nbd: don't change socket block during negotiate Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 10/16] nbd: pass export name as init argument Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 11/16] nbd: make nbd_client_session_close() idempotent Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 12/16] nbd: finish any pending coroutine Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 13/16] nbd: avoid uninitialized warnings Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 14/16] spice: move qemu_spice_display_*() from spice-graphics to spice-core Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 15/16] spice: move spice_server_vm_{start, stop} calls into qemu_spice_display_*() Gerd Hoffmann
2013-12-16  9:31 ` [Qemu-devel] [PATCH 16/16] spice: stop server for qxl hard reset Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387186277-9573-2-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).