From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43385)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VsWaC-0008Vj-Nz
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 06:43:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VsWa6-0000g7-PA
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 06:43:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:19605)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VsWa6-0000g2-HH
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 06:43:26 -0500
Message-ID: <1387194200.28883.5.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 16 Dec 2013 12:43:20 +0100
In-Reply-To: <1387186600-20389-1-git-send-email-pktoss@gmail.com>
References: <1387186600-20389-1-git-send-email-pktoss@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] usb: Remove magic constants from device
	bmAttributes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pantelis Koukousoulas <pktoss@gmail.com>
Cc: qemu-devel@nongnu.org

On Mo, 2013-12-16 at 11:36 +0200, Pantelis Koukousoulas wrote:
> Replace magic constants in device bmAttributes with symbolic ones
> from Linux kernel ch9.h

> -            .bmAttributes          = 0xc0,
> +            .bmAttributes          = USB_CONFIG_ATT_ONE | USB_CONFIG_ATT_SELFPOWER,

Looks good, but fails checkpatch with lots of "WARNING: line over 80
characters" messages.

cheers,
  Gerd