From: Gerd Hoffmann <kraxel@redhat.com>
To: Pantelis Koukousoulas <pktoss@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] usb: Remove magic constants from device bmAttributes
Date: Mon, 16 Dec 2013 15:27:17 +0100 [thread overview]
Message-ID: <1387204037.28883.50.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <CAKw_XgTLSHB_VobAAs54y=X5y3zkUUHrQS_9DFJWv2X6CpTeow@mail.gmail.com>
Hi,
> I thought that for lines that are just a logical or of constants
> it would be ok to go over 80 columns, since the alternatives
>
> (shortening the names of constants or breaking the line)
>
> are a little less readable.
I don't find the broken lines unreadable, especially if
you align the stuff nicely like you did ...
> ... and broke the two lines
> that were still longer than 80 columns,
... here.
But if you prefer it this way with the shorter constants, no problem,
I'll happily take it as-is.
cheers,
Gerd
next prev parent reply other threads:[~2013-12-16 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 9:36 [Qemu-devel] [PATCH] usb: Remove magic constants from device bmAttributes Pantelis Koukousoulas
2013-12-16 11:43 ` Gerd Hoffmann
2013-12-16 12:34 ` Pantelis Koukousoulas
2013-12-16 14:27 ` Gerd Hoffmann [this message]
2013-12-16 15:10 ` Pantelis Koukousoulas
2014-01-28 14:26 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387204037.28883.50.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=pktoss@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).