From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsZ8q-0004DD-Oa for qemu-devel@nongnu.org; Mon, 16 Dec 2013 09:27:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsZ8j-0007Ov-Rp for qemu-devel@nongnu.org; Mon, 16 Dec 2013 09:27:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsZ8j-0007OV-JA for qemu-devel@nongnu.org; Mon, 16 Dec 2013 09:27:21 -0500 Message-ID: <1387204037.28883.50.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Mon, 16 Dec 2013 15:27:17 +0100 In-Reply-To: References: <1387186600-20389-1-git-send-email-pktoss@gmail.com> <1387194200.28883.5.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] usb: Remove magic constants from device bmAttributes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pantelis Koukousoulas Cc: QEMU Developers Hi, > I thought that for lines that are just a logical or of constants > it would be ok to go over 80 columns, since the alternatives > > (shortening the names of constants or breaking the line) > > are a little less readable. I don't find the broken lines unreadable, especially if you align the stuff nicely like you did ... > ... and broke the two lines > that were still longer than 80 columns, ... here. But if you prefer it this way with the shorter constants, no problem, I'll happily take it as-is. cheers, Gerd