From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vsf8V-0006Iq-Iu for qemu-devel@nongnu.org; Mon, 16 Dec 2013 15:51:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vsf8M-0002tv-En for qemu-devel@nongnu.org; Mon, 16 Dec 2013 15:51:31 -0500 Received: from e35.co.us.ibm.com ([32.97.110.153]:59581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vsf8M-0002ti-8R for qemu-devel@nongnu.org; Mon, 16 Dec 2013 15:51:22 -0500 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Dec 2013 13:51:21 -0700 Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 7BBD53E40052 for ; Mon, 16 Dec 2013 13:51:18 -0700 (MST) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by b03cxnp08027.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rBGKpGcs6291800 for ; Mon, 16 Dec 2013 21:51:17 +0100 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id rBGKsLZW003731 for ; Mon, 16 Dec 2013 13:54:22 -0700 From: Matthew Rosato Date: Mon, 16 Dec 2013 15:51:09 -0500 Message-Id: <1387227072-21965-3-git-send-email-mjrosato@linux.vnet.ibm.com> In-Reply-To: <1387227072-21965-1-git-send-email-mjrosato@linux.vnet.ibm.com> References: <1387227072-21965-1-git-send-email-mjrosato@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 2/5] virtio-ccw: Include standby memory when calculating storage increment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: gleb@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, aliguori@amazon.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, rth@twiddle.net When determining the memory increment size, include the standby memory as well as the core memory. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio-ccw.c | 30 +++++++++++++++++++++++++----- target-s390x/cpu.h | 4 ++++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 733d988..75deb24 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -17,6 +17,8 @@ #include "css.h" #include "virtio-ccw.h" +ram_addr_t pad_size; + void io_subsystem_reset(void) { DeviceState *css, *sclp; @@ -84,11 +86,22 @@ static void ccw_init(QEMUMachineInitArgs *args) int ret; VirtualCssBus *css_bus; - /* s390x ram size detection needs a 16bit multiplier + an increment. So - guests > 64GB can be specified in 2MB steps etc. */ - while ((my_ram_size >> (20 + shift)) > 65535) { - shift++; + if (standby_mem_size) { + /* The storage increment size is a multiple of 1M and is a power of 2. + * The number of storage increments must be 1020 or fewer. */ + while ((my_ram_size >> (20 + shift)) > 1020) { + shift++; + } + while ((standby_mem_size >> (20 + shift)) > 1020) { + shift++; + } + standby_mem_size = standby_mem_size >> (20 + shift) << (20 + shift); + } else { + while ((my_ram_size >> (20 + shift)) > 65535) { + shift++; + } } + my_ram_size = my_ram_size >> (20 + shift) << (20 + shift); /* let's propagate the changed ram size into the global variable. */ @@ -103,11 +116,18 @@ static void ccw_init(QEMUMachineInitArgs *args) /* register hypercalls */ virtio_ccw_register_hcalls(); - /* allocate RAM */ + /* allocate RAM for core */ memory_region_init_ram(ram, NULL, "s390.ram", my_ram_size); vmstate_register_ram_global(ram); memory_region_add_subregion(sysmem, 0, ram); + if (standby_mem_size) { + if (my_ram_size % MEM_SECTION_SIZE) { + pad_size = MEM_SECTION_SIZE - my_ram_size % MEM_SECTION_SIZE; + } + my_ram_size += standby_mem_size + pad_size; + } + /* allocate storage keys */ storage_keys = g_malloc0(my_ram_size / TARGET_PAGE_SIZE); diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h index a2c077b..3383d55 100644 --- a/target-s390x/cpu.h +++ b/target-s390x/cpu.h @@ -385,6 +385,10 @@ unsigned s390_del_running_cpu(S390CPU *cpu); /* service interrupts are floating therefore we must not pass an cpustate */ void s390_sclp_extint(uint32_t parm); +/* from s390-virtio-ccw */ +#define MEM_SECTION_SIZE 0x10000000UL +extern ram_addr_t standby_mem_size; + /* from s390-virtio-bus */ extern const hwaddr virtio_size; -- 1.7.9.5