From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vssni-0003GF-JY for qemu-devel@nongnu.org; Tue, 17 Dec 2013 06:27:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vssnb-000474-B9 for qemu-devel@nongnu.org; Tue, 17 Dec 2013 06:26:58 -0500 Received: from mail-ea0-f169.google.com ([209.85.215.169]:49181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vssnb-00046s-6G for qemu-devel@nongnu.org; Tue, 17 Dec 2013 06:26:51 -0500 Received: by mail-ea0-f169.google.com with SMTP id l9so2417155eaj.0 for ; Tue, 17 Dec 2013 03:26:15 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 17 Dec 2013 12:26:01 +0100 Message-Id: <1387279564-517-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1387279564-517-1-git-send-email-pbonzini@redhat.com> References: <1387279564-517-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v2 2/5] qom: fix leak for objects created with -object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: imammedo@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com The object must be unref-ed when its variable goes out of scope. Signed-off-by: Paolo Bonzini --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 8d5d874..6917fd1 100644 --- a/vl.c +++ b/vl.c @@ -2807,12 +2807,13 @@ static int object_create(QemuOpts *opts, void *opaque) obj = object_new(type); if (qemu_opt_foreach(opts, object_set_property, obj, 1) < 0) { + object_unref(obj); return -1; } object_property_add_child(container_get(object_get_root(), "/objects"), id, obj, NULL); - + object_unref(obj); return 0; } -- 1.8.4.2