qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jens Freimann <jfrei@linux.vnet.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
	Alexander Graf <agraf@suse.de>
Cc: Jens Freimann <jfrei@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, Thomas Huth <thuth@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 3/8] s390x/kvm: Removed s390_store_status stub
Date: Tue, 17 Dec 2013 14:22:05 +0100	[thread overview]
Message-ID: <1387286530-31516-4-git-send-email-jfrei@linux.vnet.ibm.com> (raw)
In-Reply-To: <1387286530-31516-1-git-send-email-jfrei@linux.vnet.ibm.com>

From: Thomas Huth <thuth@linux.vnet.ibm.com>

The SIGP order STORE STATUS AT ADDRESS will be handled in
kernel space, so we do not need the stub in QEMU anymore.

Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
---
 target-s390x/kvm.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index 52d93a7..5b243b4 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -597,13 +597,6 @@ int kvm_s390_cpu_restart(S390CPU *cpu)
     return 0;
 }
 
-static int s390_store_status(CPUS390XState *env, uint32_t parameter)
-{
-    /* XXX */
-    fprintf(stderr, "XXX SIGP store status\n");
-    return -1;
-}
-
 static int s390_cpu_initial_reset(S390CPU *cpu)
 {
     CPUState *cs = CPU(cpu);
@@ -629,12 +622,9 @@ static int handle_sigp(S390CPU *cpu, struct kvm_run *run, uint8_t ipa1)
 {
     CPUS390XState *env = &cpu->env;
     uint8_t order_code;
-    uint32_t parameter;
     uint16_t cpu_addr;
-    uint8_t t;
     int r = -1;
     S390CPU *target_cpu;
-    CPUS390XState *target_env;
 
     cpu_synchronize_state(CPU(cpu));
 
@@ -645,28 +635,16 @@ static int handle_sigp(S390CPU *cpu, struct kvm_run *run, uint8_t ipa1)
     }
     order_code += (run->s390_sieic.ipb & 0x0fff0000) >> 16;
 
-    /* get parameters */
-    t = (ipa1 & 0xf0) >> 4;
-    if (!(t % 2)) {
-        t++;
-    }
-
-    parameter = env->regs[t] & 0x7ffffe00;
     cpu_addr = env->regs[ipa1 & 0x0f];
-
     target_cpu = s390_cpu_addr2state(cpu_addr);
     if (target_cpu == NULL) {
         goto out;
     }
-    target_env = &target_cpu->env;
 
     switch (order_code) {
         case SIGP_RESTART:
             r = kvm_s390_cpu_restart(target_cpu);
             break;
-        case SIGP_STORE_STATUS_ADDR:
-            r = s390_store_status(target_env, parameter);
-            break;
         case SIGP_SET_ARCH:
             /* make the caller panic */
             return -1;
-- 
1.8.3.4

  parent reply	other threads:[~2013-12-17 13:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 13:22 [Qemu-devel] [PATCH 0/8] s390 sigp, chsc and diag bugfixes/cleanups Jens Freimann
2013-12-17 13:22 ` [Qemu-devel] [PATCH 1/8] s390x/kvm: Fix diagnose handling Jens Freimann
2013-12-17 17:27   ` Jens Freimann
2013-12-17 13:22 ` [Qemu-devel] [PATCH 2/8] s390x/kvm: Removed duplicated SIGP defines Jens Freimann
2013-12-17 13:22 ` Jens Freimann [this message]
2013-12-17 13:22 ` [Qemu-devel] [PATCH 4/8] s390x/kvm: Fix coding style in handle_sigp() Jens Freimann
2013-12-17 13:22 ` [Qemu-devel] [PATCH 5/8] s390x/kvm: Implemented SIGP START Jens Freimann
2013-12-17 13:56   ` Alexander Graf
2013-12-17 14:26     ` Thomas Huth
2013-12-17 14:30       ` Alexander Graf
2013-12-17 13:22 ` [Qemu-devel] [PATCH 6/8] s390x/kvm: Simplified the calculation of the SIGP order code Jens Freimann
2013-12-17 13:22 ` [Qemu-devel] [PATCH 7/8] s390x/kvm: Fixed condition code for unknown SIGP orders Jens Freimann
2013-12-17 13:22 ` [Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition code Jens Freimann
2013-12-17 14:01   ` Alexander Graf
2013-12-17 15:50     ` Jens Freimann
2013-12-17 18:50   ` Jens Freimann
2013-12-18 13:22 ` [Qemu-devel] [PATCH 0/8] s390 sigp, chsc and diag bugfixes/cleanups Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387286530-31516-4-git-send-email-jfrei@linux.vnet.ibm.com \
    --to=jfrei@linux.vnet.ibm.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).