From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vsubc-0005mb-Sr for qemu-devel@nongnu.org; Tue, 17 Dec 2013 08:22:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsubT-00051t-QG for qemu-devel@nongnu.org; Tue, 17 Dec 2013 08:22:36 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:49851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsubT-00051L-Hc for qemu-devel@nongnu.org; Tue, 17 Dec 2013 08:22:27 -0500 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Dec 2013 13:22:26 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5FC362190063 for ; Tue, 17 Dec 2013 13:22:24 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rBHDMC7n54591666 for ; Tue, 17 Dec 2013 13:22:12 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rBHDMO4O006833 for ; Tue, 17 Dec 2013 06:22:24 -0700 From: Jens Freimann Date: Tue, 17 Dec 2013 14:22:10 +0100 Message-Id: <1387286530-31516-9-git-send-email-jfrei@linux.vnet.ibm.com> In-Reply-To: <1387286530-31516-1-git-send-email-jfrei@linux.vnet.ibm.com> References: <1387286530-31516-1-git-send-email-jfrei@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Alexander Graf Cc: Jens Freimann , qemu-devel@nongnu.org, Thomas Huth From: Thomas Huth I missed to set the CC in the CHSC instruction when I refactored the CC setting in the IO instructions with the following commit: 5d9bf1c07c1369ab3506fc82cc65a10f4415d867 s390/ioinst: Moved the CC setting to the IO instruction handlers This patch now restores the correct behaviour of CHSC by setting the condition code 0 at the end of the instruction. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann --- target-s390x/ioinst.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-s390x/ioinst.c b/target-s390x/ioinst.c index 8d6363d..b8a6486 100644 --- a/target-s390x/ioinst.c +++ b/target-s390x/ioinst.c @@ -622,6 +622,7 @@ void ioinst_handle_chsc(S390CPU *cpu, uint32_t ipb) break; } + setcc(cpu, 0); /* Command execution complete */ out: s390_cpu_physical_memory_unmap(env, req, map_size, 1); } -- 1.8.3.4