From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VswXp-0002If-PN for qemu-devel@nongnu.org; Tue, 17 Dec 2013 10:26:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VswXj-0000s2-QP for qemu-devel@nongnu.org; Tue, 17 Dec 2013 10:26:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VswXj-0000rh-Dx for qemu-devel@nongnu.org; Tue, 17 Dec 2013 10:26:43 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBHFQgA2023889 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Dec 2013 10:26:42 -0500 From: Juan Quintela Date: Tue, 17 Dec 2013 16:25:58 +0100 Message-Id: <1387293974-24718-23-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-1-git-send-email-quintela@redhat.com> References: <1387293974-24718-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 22/38] memory: cpu_physical_memory_get_dirty() is used as returning a bool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- include/exec/memory-internal.h | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index edca8a8..fa28fc6 100644 --- a/include/exec/memory-internal.h +++ b/include/exec/memory-internal.h @@ -40,11 +40,10 @@ void *qemu_get_ram_ptr(ram_addr_t addr); void qemu_ram_free(ram_addr_t addr); void qemu_ram_free_from_ptr(ram_addr_t addr); -static inline int cpu_physical_memory_get_dirty(ram_addr_t start, - ram_addr_t length, - unsigned client) +static inline bool cpu_physical_memory_get_dirty(ram_addr_t start, + ram_addr_t length, + unsigned client) { - int ret = 0; ram_addr_t addr, end; assert(client < DIRTY_MEMORY_NUM); @@ -52,10 +51,12 @@ static inline int cpu_physical_memory_get_dirty(ram_addr_t start, end = TARGET_PAGE_ALIGN(start + length); start &= TARGET_PAGE_MASK; for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) { - ret |= test_bit(addr >> TARGET_PAGE_BITS, - ram_list.dirty_memory[client]); + if (test_bit(addr >> TARGET_PAGE_BITS, + ram_list.dirty_memory[client])) { + return true; + } } - return ret; + return false; } static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr, -- 1.8.3.1