From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VswY0-0002bZ-Q0 for qemu-devel@nongnu.org; Tue, 17 Dec 2013 10:27:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VswXu-0000wd-CE for qemu-devel@nongnu.org; Tue, 17 Dec 2013 10:27:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VswXu-0000wV-42 for qemu-devel@nongnu.org; Tue, 17 Dec 2013 10:26:54 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBHFQrEF010315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Dec 2013 10:26:53 -0500 From: Juan Quintela Date: Tue, 17 Dec 2013 16:26:07 +0100 Message-Id: <1387293974-24718-32-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-1-git-send-email-quintela@redhat.com> References: <1387293974-24718-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 31/38] memory: unfold memory_region_test_and_clear() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org We are going to update the bitmap directly Signed-off-by: Juan Quintela --- arch_init.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch_init.c b/arch_init.c index e0acbc5..0e8c8b5 100644 --- a/arch_init.c +++ b/arch_init.c @@ -48,6 +48,7 @@ #include "qmp-commands.h" #include "trace.h" #include "exec/cpu-all.h" +#include "exec/ram_addr.h" #include "hw/acpi/acpi.h" #ifdef DEBUG_ARCH_INIT @@ -400,9 +401,12 @@ static void migration_bitmap_sync(void) QTAILQ_FOREACH(block, &ram_list.blocks, next) { for (addr = 0; addr < block->length; addr += TARGET_PAGE_SIZE) { - if (memory_region_test_and_clear_dirty(block->mr, - addr, TARGET_PAGE_SIZE, - DIRTY_MEMORY_MIGRATION)) { + if (cpu_physical_memory_get_dirty(block->mr->ram_addr + addr, + TARGET_PAGE_SIZE, + DIRTY_MEMORY_MIGRATION)) { + cpu_physical_memory_reset_dirty(block->mr->ram_addr + addr, + TARGET_PAGE_SIZE, + DIRTY_MEMORY_MIGRATION); migration_bitmap_set_dirty(block->mr, addr); } } -- 1.8.3.1