From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VswXW-0001il-Hw for qemu-devel@nongnu.org; Tue, 17 Dec 2013 10:26:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VswXQ-0000ev-F7 for qemu-devel@nongnu.org; Tue, 17 Dec 2013 10:26:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VswXQ-0000eb-0B for qemu-devel@nongnu.org; Tue, 17 Dec 2013 10:26:24 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBHFQNOg028432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Dec 2013 10:26:23 -0500 From: Juan Quintela Date: Tue, 17 Dec 2013 16:25:42 +0100 Message-Id: <1387293974-24718-7-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-1-git-send-email-quintela@redhat.com> References: <1387293974-24718-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 06/38] exec: create function to get a single dirty bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- exec.c | 2 +- include/exec/memory-internal.h | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 8800f8e..95bcf70 100644 --- a/exec.c +++ b/exec.c @@ -1486,7 +1486,7 @@ static void notdirty_mem_write(void *opaque, hwaddr ram_addr, { int dirty_flags; dirty_flags = cpu_physical_memory_get_dirty_flags(ram_addr); - if (!(dirty_flags & CODE_DIRTY_FLAG)) { + if (!cpu_physical_memory_get_dirty_flag(ram_addr, CODE_DIRTY_FLAG)) { tb_invalidate_phys_page_fast(ram_addr, size); dirty_flags = cpu_physical_memory_get_dirty_flags(ram_addr); } diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index 4ebab80..136198c 100644 --- a/include/exec/memory-internal.h +++ b/include/exec/memory-internal.h @@ -49,6 +49,12 @@ static inline int cpu_physical_memory_get_dirty_flags(ram_addr_t addr) return ram_list.phys_dirty[addr >> TARGET_PAGE_BITS]; } +static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr, + int dirty_flag) +{ + return ram_list.phys_dirty[addr >> TARGET_PAGE_BITS] & dirty_flag; +} + /* read dirty bit (return 0 or 1) */ static inline int cpu_physical_memory_is_dirty(ram_addr_t addr) { -- 1.8.3.1