From: Jens Freimann <jfrei@linux.vnet.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
Thomas Huth <thuth@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition code
Date: Tue, 17 Dec 2013 19:50:01 +0100 [thread overview]
Message-ID: <1387306201-63387-1-git-send-email-jfrei@linux.vnet.ibm.com> (raw)
In-Reply-To: <1387286530-31516-9-git-send-email-jfrei@linux.vnet.ibm.com>
From: Thomas Huth <thuth@linux.vnet.ibm.com>
I missed to set the CC in the CHSC instruction when I refactored
the CC setting in the IO instructions with the following commit:
5d9bf1c07c1369ab3506fc82cc65a10f4415d867
s390/ioinst: Moved the CC setting to the IO instruction handlers
This patch now restores the correct behaviour of CHSC by setting the
condition code 0 at the end of the instruction.
Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
---
target-s390x/ioinst.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target-s390x/ioinst.c b/target-s390x/ioinst.c
index 8d6363d..b8a6486 100644
--- a/target-s390x/ioinst.c
+++ b/target-s390x/ioinst.c
@@ -622,6 +622,7 @@ void ioinst_handle_chsc(S390CPU *cpu, uint32_t ipb)
break;
}
+ setcc(cpu, 0); /* Command execution complete */
out:
s390_cpu_physical_memory_unmap(env, req, map_size, 1);
}
--
1.8.3.4
next prev parent reply other threads:[~2013-12-17 18:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 13:22 [Qemu-devel] [PATCH 0/8] s390 sigp, chsc and diag bugfixes/cleanups Jens Freimann
2013-12-17 13:22 ` [Qemu-devel] [PATCH 1/8] s390x/kvm: Fix diagnose handling Jens Freimann
2013-12-17 17:27 ` Jens Freimann
2013-12-17 13:22 ` [Qemu-devel] [PATCH 2/8] s390x/kvm: Removed duplicated SIGP defines Jens Freimann
2013-12-17 13:22 ` [Qemu-devel] [PATCH 3/8] s390x/kvm: Removed s390_store_status stub Jens Freimann
2013-12-17 13:22 ` [Qemu-devel] [PATCH 4/8] s390x/kvm: Fix coding style in handle_sigp() Jens Freimann
2013-12-17 13:22 ` [Qemu-devel] [PATCH 5/8] s390x/kvm: Implemented SIGP START Jens Freimann
2013-12-17 13:56 ` Alexander Graf
2013-12-17 14:26 ` Thomas Huth
2013-12-17 14:30 ` Alexander Graf
2013-12-17 13:22 ` [Qemu-devel] [PATCH 6/8] s390x/kvm: Simplified the calculation of the SIGP order code Jens Freimann
2013-12-17 13:22 ` [Qemu-devel] [PATCH 7/8] s390x/kvm: Fixed condition code for unknown SIGP orders Jens Freimann
2013-12-17 13:22 ` [Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition code Jens Freimann
2013-12-17 14:01 ` Alexander Graf
2013-12-17 15:50 ` Jens Freimann
2013-12-17 18:50 ` Jens Freimann [this message]
2013-12-18 13:22 ` [Qemu-devel] [PATCH 0/8] s390 sigp, chsc and diag bugfixes/cleanups Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387306201-63387-1-git-send-email-jfrei@linux.vnet.ibm.com \
--to=jfrei@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=thuth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).