From: Alexander Graf <agraf@suse.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Anthony Liguori <anthony@codemonkey.ws>,
Thomas Huth <thuth@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PULL 8/8] s390x/ioinst: CHSC has to set a condition code
Date: Wed, 18 Dec 2013 14:27:41 +0100 [thread overview]
Message-ID: <1387373261-26398-9-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1387373261-26398-1-git-send-email-agraf@suse.de>
From: Thomas Huth <thuth@linux.vnet.ibm.com>
I missed to set the CC in the CHSC instruction when I refactored
the CC setting in the IO instructions with the following commit:
5d9bf1c07c1369ab3506fc82cc65a10f4415d867
s390/ioinst: Moved the CC setting to the IO instruction handlers
This patch now restores the correct behaviour of CHSC by setting the
condition code 0 at the end of the instruction.
Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
target-s390x/ioinst.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-s390x/ioinst.c b/target-s390x/ioinst.c
index 8d6363d..b8a6486 100644
--- a/target-s390x/ioinst.c
+++ b/target-s390x/ioinst.c
@@ -622,6 +622,7 @@ void ioinst_handle_chsc(S390CPU *cpu, uint32_t ipb)
break;
}
+ setcc(cpu, 0); /* Command execution complete */
out:
s390_cpu_physical_memory_unmap(env, req, map_size, 1);
}
--
1.6.0.2
next prev parent reply other threads:[~2013-12-18 13:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 13:27 [Qemu-devel] [PULL 0/8] s390 patch queue 2013-12-18 Alexander Graf
2013-12-18 13:27 ` [Qemu-devel] [PULL 1/8] s390x/kvm: Fix diagnose handling Alexander Graf
2013-12-18 13:27 ` [Qemu-devel] [PULL 2/8] s390x/kvm: Removed duplicated SIGP defines Alexander Graf
2013-12-18 13:27 ` [Qemu-devel] [PULL 3/8] s390x/kvm: Removed s390_store_status stub Alexander Graf
2013-12-18 13:27 ` [Qemu-devel] [PULL 4/8] s390x/kvm: Fix coding style in handle_sigp() Alexander Graf
2013-12-18 13:27 ` [Qemu-devel] [PULL 5/8] s390x/kvm: Implemented SIGP START Alexander Graf
2013-12-18 13:27 ` [Qemu-devel] [PULL 6/8] s390x/kvm: Simplified the calculation of the SIGP order code Alexander Graf
2013-12-18 13:27 ` [Qemu-devel] [PULL 7/8] s390x/kvm: Fixed condition code for unknown SIGP orders Alexander Graf
2013-12-18 13:27 ` Alexander Graf [this message]
2013-12-19 19:57 ` [Qemu-devel] [PULL 0/8] s390 patch queue 2013-12-18 Anthony Liguori
2013-12-19 23:02 ` Alexander Graf
2013-12-21 16:46 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387373261-26398-9-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).