From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtHAG-000145-JT for qemu-devel@nongnu.org; Wed, 18 Dec 2013 08:27:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtHA9-0002uy-2x for qemu-devel@nongnu.org; Wed, 18 Dec 2013 08:27:52 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36123 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtHA8-0002uX-SO for qemu-devel@nongnu.org; Wed, 18 Dec 2013 08:27:44 -0500 From: Alexander Graf Date: Wed, 18 Dec 2013 14:27:41 +0100 Message-Id: <1387373261-26398-9-git-send-email-agraf@suse.de> In-Reply-To: <1387373261-26398-1-git-send-email-agraf@suse.de> References: <1387373261-26398-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PULL 8/8] s390x/ioinst: CHSC has to set a condition code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: Blue Swirl , Jens Freimann , Aurelien Jarno , Anthony Liguori , Thomas Huth From: Thomas Huth I missed to set the CC in the CHSC instruction when I refactored the CC setting in the IO instructions with the following commit: 5d9bf1c07c1369ab3506fc82cc65a10f4415d867 s390/ioinst: Moved the CC setting to the IO instruction handlers This patch now restores the correct behaviour of CHSC by setting the condition code 0 at the end of the instruction. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann Signed-off-by: Alexander Graf --- target-s390x/ioinst.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/ioinst.c b/target-s390x/ioinst.c index 8d6363d..b8a6486 100644 --- a/target-s390x/ioinst.c +++ b/target-s390x/ioinst.c @@ -622,6 +622,7 @@ void ioinst_handle_chsc(S390CPU *cpu, uint32_t ipb) break; } + setcc(cpu, 0); /* Command execution complete */ out: s390_cpu_physical_memory_unmap(env, req, map_size, 1); } -- 1.6.0.2