* [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails
@ 2013-12-18 16:48 Corey Bryant
2013-12-19 11:35 ` Eduardo Otubo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Corey Bryant @ 2013-12-18 16:48 UTC (permalink / raw)
To: qemu-devel; +Cc: pmoore, Corey Bryant, aliguori, otubo
This fixes a bug where we weren't exiting if seccomp_init() failed.
Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
---
qemu-seccomp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qemu-seccomp.c b/qemu-seccomp.c
index cf07869..b7c1253 100644
--- a/qemu-seccomp.c
+++ b/qemu-seccomp.c
@@ -231,6 +231,7 @@ int seccomp_start(void)
ctx = seccomp_init(SCMP_ACT_KILL);
if (ctx == NULL) {
+ rc = -1;
goto seccomp_return;
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails
2013-12-18 16:48 [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails Corey Bryant
@ 2013-12-19 11:35 ` Eduardo Otubo
2013-12-19 15:59 ` Paul Moore
2013-12-19 20:41 ` Michael Roth
2 siblings, 0 replies; 4+ messages in thread
From: Eduardo Otubo @ 2013-12-19 11:35 UTC (permalink / raw)
To: Corey Bryant; +Cc: pmoore, qemu-devel, aliguori
On 12/18/2013 02:48 PM, Corey Bryant wrote:
> This fixes a bug where we weren't exiting if seccomp_init() failed.
>
> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
> ---
> qemu-seccomp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index cf07869..b7c1253 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -231,6 +231,7 @@ int seccomp_start(void)
>
> ctx = seccomp_init(SCMP_ACT_KILL);
> if (ctx == NULL) {
> + rc = -1;
> goto seccomp_return;
> }
>
ACK.
Reviewed-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
--
Eduardo Otubo
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails
2013-12-18 16:48 [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails Corey Bryant
2013-12-19 11:35 ` Eduardo Otubo
@ 2013-12-19 15:59 ` Paul Moore
2013-12-19 20:41 ` Michael Roth
2 siblings, 0 replies; 4+ messages in thread
From: Paul Moore @ 2013-12-19 15:59 UTC (permalink / raw)
To: Corey Bryant, otubo; +Cc: qemu-devel, aliguori
On Wednesday, December 18, 2013 11:48:11 AM Corey Bryant wrote:
> This fixes a bug where we weren't exiting if seccomp_init() failed.
>
> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
> ---
> qemu-seccomp.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Paul Moore <pmoore@redhat.com>
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index cf07869..b7c1253 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -231,6 +231,7 @@ int seccomp_start(void)
>
> ctx = seccomp_init(SCMP_ACT_KILL);
> if (ctx == NULL) {
> + rc = -1;
> goto seccomp_return;
> }
--
paul moore
security and virtualization @ redhat
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails
2013-12-18 16:48 [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails Corey Bryant
2013-12-19 11:35 ` Eduardo Otubo
2013-12-19 15:59 ` Paul Moore
@ 2013-12-19 20:41 ` Michael Roth
2 siblings, 0 replies; 4+ messages in thread
From: Michael Roth @ 2013-12-19 20:41 UTC (permalink / raw)
To: Corey Bryant, qemu-devel; +Cc: pmoore, qemu-stable, aliguori, otubo
Quoting Corey Bryant (2013-12-18 10:48:11)
> This fixes a bug where we weren't exiting if seccomp_init() failed.
>
> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc'ing qemu-stable
> ---
> qemu-seccomp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index cf07869..b7c1253 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -231,6 +231,7 @@ int seccomp_start(void)
>
> ctx = seccomp_init(SCMP_ACT_KILL);
> if (ctx == NULL) {
> + rc = -1;
> goto seccomp_return;
> }
>
> --
> 1.8.1.4
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-19 20:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-18 16:48 [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails Corey Bryant
2013-12-19 11:35 ` Eduardo Otubo
2013-12-19 15:59 ` Paul Moore
2013-12-19 20:41 ` Michael Roth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).