From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtKpu-0000zd-5V for qemu-devel@nongnu.org; Wed, 18 Dec 2013 12:23:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtKpo-00008f-3K for qemu-devel@nongnu.org; Wed, 18 Dec 2013 12:23:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtKpn-00008B-Sd for qemu-devel@nongnu.org; Wed, 18 Dec 2013 12:23:00 -0500 From: Luiz Capitulino Date: Wed, 18 Dec 2013 11:59:58 -0500 Message-Id: <1387386003-8949-9-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1387386003-8949-1-git-send-email-lcapitulino@redhat.com> References: <1387386003-8949-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PULL 08/13] rng: initialize file descriptor to -1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: qemu-devel@nongnu.org From: Paolo Bonzini The file descriptor is never initialized to -1, which makes rng-random close stdin if an object is created and immediately destroyed. If we change it to -1, we also need to protect qemu_set_fd_handler from receiving a bogus file descriptor. Signed-off-by: Paolo Bonzini Reviewed-By: Igor Mammedov Signed-off-by: Luiz Capitulino --- backends/rng-random.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/rng-random.c b/backends/rng-random.c index 68dfc8a..136499d 100644 --- a/backends/rng-random.c +++ b/backends/rng-random.c @@ -123,15 +123,15 @@ static void rng_random_init(Object *obj) NULL); s->filename = g_strdup("/dev/random"); + s->fd = -1; } static void rng_random_finalize(Object *obj) { RndRandom *s = RNG_RANDOM(obj); - qemu_set_fd_handler(s->fd, NULL, NULL, NULL); - if (s->fd != -1) { + qemu_set_fd_handler(s->fd, NULL, NULL, NULL); qemu_close(s->fd); } -- 1.8.1.4