From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc <qemu-ppc@nongnu.org>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>,
"Hervé Poussineau" <hpoussin@reactos.org>
Subject: Re: [Qemu-devel] [PATCH] PPC: fix PCI configuration space MemoryRegions for grackle/uninorth
Date: Thu, 19 Dec 2013 14:49:41 +1100 [thread overview]
Message-ID: <1387424981.15680.21.camel@pasglop> (raw)
In-Reply-To: <3A95A68A-B1B7-4DD1-8B0D-FDF5CBF1B172@suse.de>
On Wed, 2013-12-18 at 23:07 +0100, Alexander Graf wrote:
> On 18.12.2013, at 23:04, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > On Wed, 2013-12-18 at 22:24 +0100, Alexander Graf wrote:
> >> Then I don't understand why we break when we limit the data region to
> >> 4 bytes.
> >
> > This is old uninorth, not U3 HT right ? The latter is memory mapped.
>
> Depends, we use the same code to cover both. With 32bit guests we expose an old UniNorth.
> With 64bit guests we have to expose a U3 as the guest doesn't know what old UniNorth is anymore.
>
> So yeah, maybe that's biting us.
Well, it's different.
Old uninorth uses some form of indirect address/data registers, as does
U3 AGP... but U3 HT uses memory mapped. So U3 has a bit of both :)
I think U4 PCIe is yet another beast as well.
Cheers,
Ben.
prev parent reply other threads:[~2013-12-19 3:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 10:53 [Qemu-devel] [PATCH] PPC: fix PCI configuration space MemoryRegions for grackle/uninorth Mark Cave-Ayland
2013-10-11 18:43 ` Hervé Poussineau
2013-11-08 3:20 ` Alexander Graf
2013-11-08 22:18 ` Mark Cave-Ayland
2013-12-18 12:34 ` Alexander Graf
2013-12-18 21:04 ` Benjamin Herrenschmidt
2013-12-18 21:24 ` Alexander Graf
2013-12-18 22:04 ` Benjamin Herrenschmidt
2013-12-18 22:07 ` Alexander Graf
2013-12-18 22:10 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2013-12-19 3:49 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387424981.15680.21.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).