qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: edgar.iglesias@gmail.com
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, blauwirbel@gmail.com,
	aliguori@amazon.com, pcrost@xilinx.com, pbonzini@redhat.com,
	afaerber@suse.de, aurelien@aurel32.net, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v2 21/22] petalogix-ml605: Create the CPU with object_new()
Date: Thu, 19 Dec 2013 15:51:32 +1000	[thread overview]
Message-ID: <1387432293-17711-22-git-send-email-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <1387432293-17711-1-git-send-email-edgar.iglesias@gmail.com>

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

This is to allow future patches to set properties before cpu::realize().

Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
 hw/microblaze/petalogix_ml605_mmu.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogix_ml605_mmu.c
index 10970e0..4009ff5 100644
--- a/hw/microblaze/petalogix_ml605_mmu.c
+++ b/hw/microblaze/petalogix_ml605_mmu.c
@@ -76,7 +76,7 @@ static void
 petalogix_ml605_init(QEMUMachineInitArgs *args)
 {
     ram_addr_t ram_size = args->ram_size;
-    const char *cpu_model = args->cpu_model;
+    Error *err = NULL;
     MemoryRegion *address_space_mem = get_system_memory();
     DeviceState *dev, *dma, *eth0;
     Object *ds, *cs;
@@ -91,10 +91,13 @@ petalogix_ml605_init(QEMUMachineInitArgs *args)
     qemu_irq irq[32], *cpu_irq;
 
     /* init CPUs */
-    if (cpu_model == NULL) {
-        cpu_model = "microblaze";
+    cpu = MICROBLAZE_CPU(object_new(TYPE_MICROBLAZE_CPU));
+    object_property_set_bool(OBJECT(cpu), true, "realized", &err);
+    if (err) {
+        error_report("%s", error_get_pretty(err));
+        exit(EXIT_FAILURE);
     }
-    cpu = cpu_mb_init(cpu_model);
+
     env = &cpu->env;
 
     /* Attach emulated BRAM through the LMB.  */
-- 
1.7.10.4

  parent reply	other threads:[~2013-12-19  6:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19  5:51 [Qemu-devel] [PATCH v2 00/22] Steps towards per CPU address-spaces edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 01/22] exec: Make tb_invalidate_phys_addr input an AS edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 02/22] exec: Make iotlb_to_region " edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 03/22] exec: Always initialize MemorySection address spaces edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 04/22] exec: Make memory_region_section_get_iotlb use section AS edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 05/22] memory: Add MemoryListener to typedefs.h edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 06/22] cpu: Add per-cpu address space edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 07/22] exec: On AS changes, only flush affected CPU TLBs edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 08/22] exec: Make ldl_*_phys input an AddressSpace edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 09/22] exec: Make ldq/ldub_*_phys " edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 10/22] exec: Make lduw_*_phys " edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 11/22] exec: Make stq_*_phys " edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 12/22] exec: Make stl_*_phys " edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 13/22] exec: Make stl_phys_notdirty " edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 14/22] exec: Make stw_*_phys " edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 15/22] exec: Make stb_phys " edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 16/22] exec: Make cpu_physical_memory_write_rom input an AS edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 17/22] exec: Make cpu_memory_rw_debug use the CPUs AS edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 18/22] memory: Add address_space_find_by_name() edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 19/22] qdev: Add qdev property type for AddressSpaces edgar.iglesias
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 20/22] target-microblaze: Add address-space property edgar.iglesias
2013-12-19  6:22   ` Peter Crosthwaite
2013-12-19  7:05     ` Edgar E. Iglesias
2013-12-19  5:51 ` edgar.iglesias [this message]
2013-12-19  5:51 ` [Qemu-devel] [PATCH v2 22/22] petalogix-ml605: Make the LMB visible only to the CPU edgar.iglesias
2013-12-19  6:37   ` Peter Crosthwaite
2013-12-19  7:10     ` Edgar E. Iglesias
2013-12-19 12:46       ` Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387432293-17711-22-git-send-email-edgar.iglesias@gmail.com \
    --to=edgar.iglesias@gmail.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@amazon.com \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=pcrost@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).