qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mike Qiu <qiudayu@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Mike Qiu <qiudayu@linux.vnet.ibm.com>, aliguori@amazon.com
Subject: [Qemu-devel] [PATCH] vl: Fix compile issue with Werror option
Date: Fri, 20 Dec 2013 01:29:50 -0500	[thread overview]
Message-ID: <1387520990-3228-1-git-send-email-qiudayu@linux.vnet.ibm.com> (raw)

Currently, if compile with Werror option, the error message shows
below:

  GEN   config-host.h
  GEN   trace/generated-tracers.h
        CHK version_gen.h
  GEN   trace/generated-tracers.c
  CC    vl.o
vl.c: In function ‘get_boot_devices_list’:
vl.c:1257:21: error: ‘bootpath’ may be used uninitialized
	in this function [-Werror=maybe-uninitialized]
         len = strlen(bootpath) + 1;
                     ^
cc1: all warnings being treated as errors
make: *** [vl.o] Error 1

This patch is to solve this issue.

Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
---
 vl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vl.c b/vl.c
index b97728f..d67b284 100644
--- a/vl.c
+++ b/vl.c
@@ -1230,7 +1230,7 @@ char *get_boot_devices_list(size_t *size, bool ignore_suffixes)
     char *list = NULL;
 
     QTAILQ_FOREACH(i, &fw_boot_order, link) {
-        char *devpath = NULL, *bootpath;
+        char *devpath = NULL, *bootpath = NULL;
         size_t len;
 
         if (i->dev) {
-- 
1.8.2.1

             reply	other threads:[~2013-12-20  6:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-20  6:29 Mike Qiu [this message]
2013-12-21 10:46 ` [Qemu-devel] [PATCH] vl: Fix compile issue with Werror option Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387520990-3228-1-git-send-email-qiudayu@linux.vnet.ibm.com \
    --to=qiudayu@linux.vnet.ibm.com \
    --cc=aliguori@amazon.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).