From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vu4nr-0002x6-24 for qemu-devel@nongnu.org; Fri, 20 Dec 2013 13:28:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vu4nl-0001HS-40 for qemu-devel@nongnu.org; Fri, 20 Dec 2013 13:28:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vu4nk-0001HN-SE for qemu-devel@nongnu.org; Fri, 20 Dec 2013 13:27:57 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBKIRuUx023565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 20 Dec 2013 13:27:56 -0500 From: Max Reitz Date: Fri, 20 Dec 2013 19:28:02 +0100 Message-Id: <1387564104-15315-3-git-send-email-mreitz@redhat.com> In-Reply-To: <1387564104-15315-1-git-send-email-mreitz@redhat.com> References: <1387564104-15315-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v7 02/24] blkdebug: Don't require sophisticated filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi , Max Reitz If the filename is not prefixed by "blkdebug:" in blkdebug_parse_filename(), the blkdebug driver was not selected through that protocol prefix, but by an explicit command line option (file.driver=blkdebug or something similar). Contrary to the current reaction, this is not a problem at all; we just need to store the filename (in the x-image option) and can go on; the user just has to manually specify the config option. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake --- block/blkdebug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 2eb2e8b..fab76ce 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -313,7 +313,9 @@ static void blkdebug_parse_filename(const char *filename, QDict *options, /* Parse the blkdebug: prefix */ if (!strstart(filename, "blkdebug:", &filename)) { - error_setg(errp, "File name string must start with 'blkdebug:'"); + /* There was no prefix; therefore, all options have to be already + present in the QDict (except for the filename) */ + qdict_put(options, "x-image", qstring_from_str(filename)); return; } -- 1.8.5.1