* [Qemu-devel] [PULL 00/01] seccomp: exit if seccomp_init() fails
@ 2013-12-20 18:50 Eduardo Otubo
2013-12-20 18:50 ` [Qemu-devel] [PULL 01/01] " Eduardo Otubo
2014-01-07 16:30 ` [Qemu-devel] [PULL 00/01] " Markus Armbruster
0 siblings, 2 replies; 4+ messages in thread
From: Eduardo Otubo @ 2013-12-20 18:50 UTC (permalink / raw)
To: qemu-devel; +Cc: pmoore, coreyb, aliguori, Eduardo Otubo
The following changes since commit 2a13f991123fa16841e6d94b02a9cc2c76d91725:
seccomp: exit if seccomp_init() fails (2013-12-20 16:38:29 -0200)
are available in the git repository at:
git://github.com/otubo/qemu.git seccomp
Corey Bryant (1):
seccomp: exit if seccomp_init() fails
qemu-seccomp.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [PULL 01/01] seccomp: exit if seccomp_init() fails
2013-12-20 18:50 [Qemu-devel] [PULL 00/01] seccomp: exit if seccomp_init() fails Eduardo Otubo
@ 2013-12-20 18:50 ` Eduardo Otubo
2014-01-07 16:30 ` [Qemu-devel] [PULL 00/01] " Markus Armbruster
1 sibling, 0 replies; 4+ messages in thread
From: Eduardo Otubo @ 2013-12-20 18:50 UTC (permalink / raw)
To: qemu-devel; +Cc: pmoore, coreyb, aliguori
From: Corey Bryant <coreyb@linux.vnet.ibm.com>
This fixes a bug where we weren't exiting if seccomp_init() failed.
Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
Acked-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
Acked-by: Paul Moore <pmoore@redhat.com>
---
qemu-seccomp.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/qemu-seccomp.c b/qemu-seccomp.c
index cf07869..b7c1253 100644
--- a/qemu-seccomp.c
+++ b/qemu-seccomp.c
@@ -231,6 +231,7 @@ int seccomp_start(void)
ctx = seccomp_init(SCMP_ACT_KILL);
if (ctx == NULL) {
+ rc = -1;
goto seccomp_return;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PULL 00/01] seccomp: exit if seccomp_init() fails
2013-12-20 18:50 [Qemu-devel] [PULL 00/01] seccomp: exit if seccomp_init() fails Eduardo Otubo
2013-12-20 18:50 ` [Qemu-devel] [PULL 01/01] " Eduardo Otubo
@ 2014-01-07 16:30 ` Markus Armbruster
2014-01-09 21:35 ` Paul Moore
1 sibling, 1 reply; 4+ messages in thread
From: Markus Armbruster @ 2014-01-07 16:30 UTC (permalink / raw)
To: Eduardo Otubo; +Cc: pmoore, coreyb, qemu-devel, aliguori
Eduardo Otubo <otubo@linux.vnet.ibm.com> writes:
> The following changes since commit 2a13f991123fa16841e6d94b02a9cc2c76d91725:
>
> seccomp: exit if seccomp_init() fails (2013-12-20 16:38:29 -0200)
>
> are available in the git repository at:
> git://github.com/otubo/qemu.git seccomp
It's been almost three weeks. What's holding this up?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PULL 00/01] seccomp: exit if seccomp_init() fails
2014-01-07 16:30 ` [Qemu-devel] [PULL 00/01] " Markus Armbruster
@ 2014-01-09 21:35 ` Paul Moore
0 siblings, 0 replies; 4+ messages in thread
From: Paul Moore @ 2014-01-09 21:35 UTC (permalink / raw)
To: Eduardo Otubo, aliguori; +Cc: coreyb, Markus Armbruster, qemu-devel
On Tuesday, January 07, 2014 05:30:32 PM Markus Armbruster wrote:
> Eduardo Otubo <otubo@linux.vnet.ibm.com> writes:
> > The following changes since commit
2a13f991123fa16841e6d94b02a9cc2c76d91725:
> > seccomp: exit if seccomp_init() fails (2013-12-20 16:38:29 -0200)
> >
> > are available in the git repository at:
> > git://github.com/otubo/qemu.git seccomp
>
> It's been almost three weeks. What's holding this up?
Agreed, this is silly, especially for such a small and obvious fix.
--
paul moore
security and virtualization @ redhat
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-09 21:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-20 18:50 [Qemu-devel] [PULL 00/01] seccomp: exit if seccomp_init() fails Eduardo Otubo
2013-12-20 18:50 ` [Qemu-devel] [PULL 01/01] " Eduardo Otubo
2014-01-07 16:30 ` [Qemu-devel] [PULL 00/01] " Markus Armbruster
2014-01-09 21:35 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).