From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vu8Rl-00085r-3p for qemu-devel@nongnu.org; Fri, 20 Dec 2013 17:21:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vu8Rc-0005cW-JR for qemu-devel@nongnu.org; Fri, 20 Dec 2013 17:21:29 -0500 Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:48156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vu8Rc-0005cN-BR for qemu-devel@nongnu.org; Fri, 20 Dec 2013 17:21:20 -0500 Received: by mail-ea0-f176.google.com with SMTP id h14so1308515eaj.7 for ; Fri, 20 Dec 2013 14:21:19 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 20 Dec 2013 23:21:06 +0100 Message-Id: <1387578070-2884-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1387578070-2884-1-git-send-email-pbonzini@redhat.com> References: <1387578070-2884-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v3 1/5] rng: initialize file descriptor to -1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: imammedo@redhat.com, afaerber@suse.de, lcapitulino@xilinx.com The file descriptor is never initialized to -1, which makes rng-random close stdin if an object is created and immediately destroyed. If we change it to -1, we also need to protect qemu_set_fd_handler from receiving a bogus file descriptor. Signed-off-by: Paolo Bonzini --- backends/rng-random.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/rng-random.c b/backends/rng-random.c index 68dfc8a..136499d 100644 --- a/backends/rng-random.c +++ b/backends/rng-random.c @@ -123,15 +123,15 @@ static void rng_random_init(Object *obj) NULL); s->filename = g_strdup("/dev/random"); + s->fd = -1; } static void rng_random_finalize(Object *obj) { RndRandom *s = RNG_RANDOM(obj); - qemu_set_fd_handler(s->fd, NULL, NULL, NULL); - if (s->fd != -1) { + qemu_set_fd_handler(s->fd, NULL, NULL, NULL); qemu_close(s->fd); } -- 1.8.4.2