* [Qemu-devel] [PATCH] pxa27x: Reduce size of keyboard matrix mapping
@ 2013-12-22 14:32 Stefan Weil
2013-12-22 15:14 ` Peter Maydell
2013-12-23 12:10 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2013-12-22 14:32 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Peter Maydell, Stefan Weil
The row and column values use only a very limited range (-1 ... 7),
so a byte value is sufficient.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
include/hw/arm/pxa.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/arm/pxa.h b/include/hw/arm/pxa.h
index d146c58..7ca330a 100644
--- a/include/hw/arm/pxa.h
+++ b/include/hw/arm/pxa.h
@@ -102,8 +102,8 @@ void pxa2xx_pcmcia_set_irq_cb(void *opaque, qemu_irq irq, qemu_irq cd_irq);
/* pxa2xx_keypad.c */
struct keymap {
- int column;
- int row;
+ int8_t column;
+ int8_t row;
};
typedef struct PXA2xxKeyPadState PXA2xxKeyPadState;
PXA2xxKeyPadState *pxa27x_keypad_init(MemoryRegion *sysmem,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] pxa27x: Reduce size of keyboard matrix mapping
2013-12-22 14:32 [Qemu-devel] [PATCH] pxa27x: Reduce size of keyboard matrix mapping Stefan Weil
@ 2013-12-22 15:14 ` Peter Maydell
2013-12-23 12:10 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2013-12-22 15:14 UTC (permalink / raw)
To: Stefan Weil; +Cc: QEMU Trivial, QEMU Developers
On 22 December 2013 14:32, Stefan Weil <sw@weilnetz.de> wrote:
> The row and column values use only a very limited range (-1 ... 7),
> so a byte value is sufficient.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
It's not like we have a ton of pxa2xx keymaps eating up
space, but yeah, this is an OK change.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] pxa27x: Reduce size of keyboard matrix mapping
2013-12-22 14:32 [Qemu-devel] [PATCH] pxa27x: Reduce size of keyboard matrix mapping Stefan Weil
2013-12-22 15:14 ` Peter Maydell
@ 2013-12-23 12:10 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2013-12-23 12:10 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, Peter Maydell, qemu-devel
22.12.2013 18:32, Stefan Weil wrote:
> The row and column values use only a very limited range (-1 ... 7),
> so a byte value is sufficient.
Thanks, applied to the trivial-patches queue.
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-23 12:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-22 14:32 [Qemu-devel] [PATCH] pxa27x: Reduce size of keyboard matrix mapping Stefan Weil
2013-12-22 15:14 ` Peter Maydell
2013-12-23 12:10 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).