* [Qemu-devel] [PATCH] ui/cocoa: Remove stray tabs
@ 2013-12-24 11:54 Peter Maydell
2013-12-24 12:00 ` Stefan Weil
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2013-12-24 11:54 UTC (permalink / raw)
To: qemu-devel; +Cc: Andreas Färber, patches
The ui/cocoa.m file has just three lines with hardcoded tabs; fix them.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
I'm generally fairly conservative about "fix indent" patches,
but three lines seems sufficiently minimal to be worth just
zapping. Happy to drop this if people disagree.
ui/cocoa.m | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index 39c62ad..58460a0 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -428,8 +428,8 @@ QemuCocoaView *cocoaView;
CGDataProviderRelease(dataProviderRef);
//sync host window color space with guests
- screen.bitsPerPixel = surface_bits_per_pixel(surface);
- screen.bitsPerComponent = surface_bytes_per_pixel(surface) * 2;
+ screen.bitsPerPixel = surface_bits_per_pixel(surface);
+ screen.bitsPerComponent = surface_bytes_per_pixel(surface) * 2;
dataProviderRef = CGDataProviderCreateWithData(NULL, surface_data(surface), w * 4 * h, NULL);
@@ -775,7 +775,7 @@ QemuCocoaView *cocoaView;
[normalWindow setContentView:cocoaView];
[normalWindow useOptimizedDrawing:YES];
[normalWindow makeKeyAndOrderFront:self];
- [normalWindow center];
+ [normalWindow center];
}
return self;
--
1.7.11.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] ui/cocoa: Remove stray tabs
2013-12-24 11:54 [Qemu-devel] [PATCH] ui/cocoa: Remove stray tabs Peter Maydell
@ 2013-12-24 12:00 ` Stefan Weil
2013-12-24 12:05 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2013-12-24 12:00 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: qemu-trivial, Andreas Färber, patches
Am 24.12.2013 12:54, schrieb Peter Maydell:
> The ui/cocoa.m file has just three lines with hardcoded tabs; fix them.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I'm generally fairly conservative about "fix indent" patches,
> but three lines seems sufficiently minimal to be worth just
> zapping. Happy to drop this if people disagree.
>
> ui/cocoa.m | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
CCing qemu-trivial
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] ui/cocoa: Remove stray tabs
2013-12-24 12:00 ` Stefan Weil
@ 2013-12-24 12:05 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2013-12-24 12:05 UTC (permalink / raw)
To: Stefan Weil
Cc: qemu-trivial, Andreas Färber, QEMU Developers,
Patch Tracking
On 24 December 2013 12:00, Stefan Weil <sw@weilnetz.de> wrote:
> Am 24.12.2013 12:54, schrieb Peter Maydell:
>> The ui/cocoa.m file has just three lines with hardcoded tabs; fix them.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> I'm generally fairly conservative about "fix indent" patches,
>> but three lines seems sufficiently minimal to be worth just
>> zapping. Happy to drop this if people disagree.
>>
>> ui/cocoa.m | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> CCing qemu-trivial
Oops, what I meant to say in the below-the-line bit was:
This patch sits on top of my other recent cocoa patches.
I'm planning to send it in with a cocoa pullreq, so it doesn't
need to go via trivial.
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-24 12:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-24 11:54 [Qemu-devel] [PATCH] ui/cocoa: Remove stray tabs Peter Maydell
2013-12-24 12:00 ` Stefan Weil
2013-12-24 12:05 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).