From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>,
"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 02/10] cputlb: Tidy memset() of arrays
Date: Tue, 24 Dec 2013 13:58:53 +0100 [thread overview]
Message-ID: <1387889941-9896-3-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1387889941-9896-1-git-send-email-afaerber@suse.de>
From: Richard Henderson <rth@twiddle.net>
Don't duplicate the array length computation in the memset()
when plain sizeof() can produce the correct results.
Signed-off-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
cputlb.c | 2 +-
translate-all.c | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/cputlb.c b/cputlb.c
index d2da404..9270055 100644
--- a/cputlb.c
+++ b/cputlb.c
@@ -57,7 +57,7 @@ void tlb_flush(CPUArchState *env, int flush_global)
cpu->current_tb = NULL;
memset(env->tlb_table, -1, sizeof(env->tlb_table));
- memset(env->tb_jmp_cache, 0, TB_JMP_CACHE_SIZE * sizeof (void *));
+ memset(env->tb_jmp_cache, 0, sizeof(env->tb_jmp_cache));
env->tlb_flush_addr = -1;
env->tlb_flush_mask = 0;
diff --git a/translate-all.c b/translate-all.c
index 1c63d78..105c25a 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -703,11 +703,10 @@ void tb_flush(CPUArchState *env1)
CPU_FOREACH(cpu) {
CPUArchState *env = cpu->env_ptr;
- memset(env->tb_jmp_cache, 0, TB_JMP_CACHE_SIZE * sizeof(void *));
+ memset(env->tb_jmp_cache, 0, sizeof(env->tb_jmp_cache));
}
- memset(tcg_ctx.tb_ctx.tb_phys_hash, 0,
- CODE_GEN_PHYS_HASH_SIZE * sizeof(void *));
+ memset(tcg_ctx.tb_ctx.tb_phys_hash, 0, sizeof(tcg_ctx.tb_ctx.tb_phys_hash));
page_flush_tb();
tcg_ctx.code_gen_ptr = tcg_ctx.code_gen_buffer;
--
1.8.4
next prev parent reply other threads:[~2013-12-24 12:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 12:58 [Qemu-devel] [PULL 00/10] QOM CPUState patch queue 2013-12-24 Andreas Färber
2013-12-24 12:58 ` [Qemu-devel] [PULL 01/10] cputlb: Use memset() when flushing entries Andreas Färber
2013-12-24 12:58 ` Andreas Färber [this message]
2013-12-24 12:58 ` [Qemu-devel] [PULL 03/10] target-i386: Move apic_state field from CPUX86State to X86CPU Andreas Färber
2013-12-24 12:58 ` [Qemu-devel] [PULL 04/10] cpu-exec: Optimize X86CPU usage in cpu_exec() Andreas Färber
2013-12-24 12:58 ` [Qemu-devel] [PULL 05/10] target-i386: Convert 'hv_relaxed' to static property Andreas Färber
2013-12-24 12:58 ` [Qemu-devel] [PULL 06/10] target-i386: Convert 'hv_vapic' " Andreas Färber
2013-12-24 12:58 ` [Qemu-devel] [PULL 07/10] target-i386: Convert 'hv_spinlocks' " Andreas Färber
2013-12-24 12:58 ` [Qemu-devel] [PULL 08/10] target-i386: Convert 'check' and 'enforce' to static properties Andreas Färber
2013-12-24 12:59 ` [Qemu-devel] [PULL 09/10] target-i386: Cleanup 'foo' feature handling Andreas Färber
2013-12-24 12:59 ` [Qemu-devel] [PULL 10/10] target-i386: Cleanup 'foo=val' " Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387889941-9896-3-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).