From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vw8ku-00019Z-GO for qemu-devel@nongnu.org; Thu, 26 Dec 2013 06:05:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vw8ko-00078x-W3 for qemu-devel@nongnu.org; Thu, 26 Dec 2013 06:05:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38454) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vw8ko-00078m-MX for qemu-devel@nongnu.org; Thu, 26 Dec 2013 06:05:26 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBQB5QLV020789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 26 Dec 2013 06:05:26 -0500 Message-ID: <1388055916.6479.24.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Thu, 26 Dec 2013 13:05:16 +0200 In-Reply-To: <20131226105306.GB22584@redhat.com> References: <1388054651-13764-1-git-send-email-marcel.a@redhat.com> <1388054651-13764-2-git-send-email-marcel.a@redhat.com> <20131226105306.GB22584@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] acpi unit-test: added script to rebuild the expected aml files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On Thu, 2013-12-26 at 12:53 +0200, Michael S. Tsirkin wrote: > On Thu, Dec 26, 2013 at 12:44:10PM +0200, Marcel Apfelbaum wrote: > > Acpi unit-test will fail every time the acpi tables change. > > This script rebuilds the expected aml files, so the test > > will pass. It also validates the modifications. > > > > Signed-off-by: Marcel Apfelbaum > > --- > > tests/acpi-test-data/rebuild-expected-aml.sh | 36 ++++++++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > create mode 100755 tests/acpi-test-data/rebuild-expected-aml.sh > > > > diff --git a/tests/acpi-test-data/rebuild-expected-aml.sh b/tests/acpi-test-data/rebuild-expected-aml.sh > > new file mode 100755 > > index 0000000..8039718 > > --- /dev/null > > +++ b/tests/acpi-test-data/rebuild-expected-aml.sh > > @@ -0,0 +1,36 @@ > > +#! /bin/bash > > + > > +# > > +# Rebuild expected AML files for acpi unit-test > > +# > > +# Copyright (c) 2013 Red Hat Inc. > > +# > > +# Authors: > > +# Marcel Apfelbaum > > +# > > +# This work is licensed under the terms of the GNU GPLv2. > > +# See the COPYING.LIB file in the top-level directory. > > + > > +qemu= > > + > > +if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then > > + qemu="x86_64-softmmu/qemu-system-x86_64" > > +elif [ -e i386-softmmu/qemu-system-i386 ]; then > > + qemu="i386-softmmu/qemu-system-i386" > > +else > > + echo "Qemu executable qemu-system-x86_64 or qemu-system-i386 is required!" > > maybe add "run make to build the executable" OK > > > + echo "Run this script from the build directory." > > + exit -1; > > +fi > > + > > +if [ ! -e "tests/acpi-test" ]; then > > + echo "Test: acpi-test is required! Run make check before this script." > > + echo "Run this script from the build directory." > > + exit -1; > > you want exit 1 or some other positive value. Sure > > > +fi > > + > > +ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/acpi-test > > + > > +echo "The files were rebuild and can be added to git." > > rebuilt Sure, Thanks, Marcel > > > +echo "However, if new files were created, please copy them manually" \ > > + "to tests/acpi-test-data/pc/ or tests/acpi-test-data/q35/ ." > > -- > > 1.8.3.1