qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel.a@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com
Subject: [Qemu-devel] [PATCH v2 1/2] acpi unit-test: added script to rebuild the expected aml files
Date: Thu, 26 Dec 2013 14:19:49 +0200	[thread overview]
Message-ID: <1388060390-16447-2-git-send-email-marcel.a@redhat.com> (raw)
In-Reply-To: <1388060390-16447-1-git-send-email-marcel.a@redhat.com>

Acpi unit-test will fail every time the acpi tables change.
This script rebuild the expected aml files, so the test
will pass. It also validates the modifications.

Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
---
v1 -> v2:
Addressed Michael S. Tsirkin's comments:
 - added TEST_ prefix to the environment variable
 - some rephrases

tests/acpi-test-data/rebuild-expected-aml.sh | 36 ++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100755 tests/acpi-test-data/rebuild-expected-aml.sh

diff --git a/tests/acpi-test-data/rebuild-expected-aml.sh b/tests/acpi-test-data/rebuild-expected-aml.sh
new file mode 100755
index 0000000..6753469
--- /dev/null
+++ b/tests/acpi-test-data/rebuild-expected-aml.sh
@@ -0,0 +1,36 @@
+#! /bin/bash
+
+#
+# Rebuild expected AML files for acpi unit-test 
+#
+# Copyright (c) 2013 Red Hat Inc.
+#
+# Authors:
+#  Marcel Apfelbaum <marcel.a@redhat.com>
+#
+# This work is licensed under the terms of the GNU GPLv2.
+# See the COPYING.LIB file in the top-level directory.
+
+qemu=
+
+if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then
+    qemu="x86_64-softmmu/qemu-system-x86_64"
+elif [ -e i386-softmmu/qemu-system-i386 ]; then
+    qemu="i386-softmmu/qemu-system-i386"
+else
+    echo "Run 'make' to build the qemu exectutable!"
+    echo "Run this script from the build directory."
+    exit 1;
+fi
+
+if [ ! -e "tests/acpi-test" ]; then
+    echo "Test: acpi-test is required! Run make check before this script."
+    echo "Run this script from the build directory."
+    exit 1;
+fi
+
+TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/acpi-test
+
+echo "The files were rebuilt and can be added to git."
+echo "However, if new files were created, please copy them manually" \
+     "to tests/acpi-test-data/pc/ or tests/acpi-test-data/q35/ ."
-- 
1.8.3.1

  reply	other threads:[~2013-12-26 12:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-26 12:19 [Qemu-devel] [PATCH v2 0/2] acpi unit-test: rebuild aml files functionality Marcel Apfelbaum
2013-12-26 12:19 ` Marcel Apfelbaum [this message]
2013-12-26 13:54   ` [Qemu-devel] [PATCH v2 1/2] acpi unit-test: added script to rebuild the expected aml files Michael S. Tsirkin
2013-12-26 12:19 ` [Qemu-devel] [PATCH v2 2/2] acpi unit-test: hook to rebuild " Marcel Apfelbaum
2013-12-26 12:46 ` [Qemu-devel] [PATCH v2 0/2] acpi unit-test: rebuild aml files functionality Michael S. Tsirkin
2013-12-26 13:24   ` Marcel Apfelbaum
2013-12-26 13:53     ` Michael S. Tsirkin
2013-12-26 14:09       ` Marcel Apfelbaum
2013-12-26 15:41         ` Michael S. Tsirkin
2013-12-26 15:58           ` Marcel Apfelbaum
2013-12-26 16:12             ` Michael S. Tsirkin
2013-12-26 16:51               ` Michael S. Tsirkin
2013-12-26 17:15                 ` Marcel Apfelbaum
2013-12-26 18:19                   ` Michael S. Tsirkin
2013-12-26 22:01                     ` Marcel Apfelbaum
2013-12-29 12:45                       ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388060390-16447-2-git-send-email-marcel.a@redhat.com \
    --to=marcel.a@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).