From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1VwAvi-00049R-7j
	for qemu-devel@nongnu.org; Thu, 26 Dec 2013 08:24:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1VwAvc-0004Ej-Tg
	for qemu-devel@nongnu.org; Thu, 26 Dec 2013 08:24:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:62263)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1VwAvc-0004Ed-Ke
	for qemu-devel@nongnu.org; Thu, 26 Dec 2013 08:24:44 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBQDOhsh024233
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 26 Dec 2013 08:24:43 -0500
Message-ID: <1388064268.17391.3.camel@localhost.localdomain>
From: Marcel Apfelbaum <marcel.a@redhat.com>
In-Reply-To: <20131226124643.GA26225@redhat.com>
References: <1388060390-16447-1-git-send-email-marcel.a@redhat.com>
	<20131226124643.GA26225@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 26 Dec 2013 15:24:28 +0200
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/2] acpi unit-test: rebuild aml files
 functionality
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, 2013-12-26 at 14:46 +0200, Michael S. Tsirkin wrote:
> On Thu, Dec 26, 2013 at 02:19:48PM +0200, Marcel Apfelbaum wrote:
> > Acpi unit-test will fail every time the acpi tables change.
> > 
> > The series adds a script that rebuilds the expected aml files, so the test
> > will pass. It also validates the modifications.
> > 
> > The acpi unit test will rebuild the aml tables if TEST_ACPI_REBUILD_AML
> > environment variable is set.
> 
> OK I had to fix some trailing whitespace, otherwise
> looks good.
> I applied it all, pls check the pci branch.
Thanks!
I pulled the pci branch, but I did not see the patches yet. 
I used git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git,
pci branch.

Thanks,
Marcel

> > v1 -> v2:
> > Addressed Michael S. Tsirkin's comments:
> >  - added TEST_ prefix to the environment variable
> >  - some rephrases
> > 
> > Marcel Apfelbaum (2):
> >   acpi unit-test: added script to rebuild the expected aml files
> >   acpi unit-test: hook to rebuild expected aml files
> > 
> >  tests/acpi-test-data/rebuild-expected-aml.sh | 36 ++++++++++++++++++++++++++++
> >  tests/acpi-test.c                            | 30 +++++++++++++++++++----
> >  2 files changed, 61 insertions(+), 5 deletions(-)
> >  create mode 100755 tests/acpi-test-data/rebuild-expected-aml.sh
> > 
> > -- 
> > 1.8.3.1
>