From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwIzW-0002rr-MC for qemu-devel@nongnu.org; Thu, 26 Dec 2013 17:01:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VwIzQ-0001JD-M1 for qemu-devel@nongnu.org; Thu, 26 Dec 2013 17:01:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwIzQ-0001J9-Db for qemu-devel@nongnu.org; Thu, 26 Dec 2013 17:01:12 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBQM1Bn6027088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 26 Dec 2013 17:01:11 -0500 Message-ID: <1388095265.17391.24.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Fri, 27 Dec 2013 00:01:05 +0200 In-Reply-To: <20131226181908.GA10012@redhat.com> References: <1388060390-16447-1-git-send-email-marcel.a@redhat.com> <20131226124643.GA26225@redhat.com> <1388064268.17391.3.camel@localhost.localdomain> <20131226135325.GA16506@redhat.com> <1388066998.17391.10.camel@localhost.localdomain> <20131226154103.GA8701@redhat.com> <1388073489.17391.20.camel@localhost.localdomain> <20131226161225.GA9003@redhat.com> <20131226165121.GA9813@redhat.com> <1388078100.17391.22.camel@localhost.localdomain> <20131226181908.GA10012@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] acpi unit-test: rebuild aml files functionality List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On Thu, 2013-12-26 at 20:19 +0200, Michael S. Tsirkin wrote: > On Thu, Dec 26, 2013 at 07:15:00PM +0200, Marcel Apfelbaum wrote: > > On Thu, 2013-12-26 at 18:51 +0200, Michael S. Tsirkin wrote: > > > On Thu, Dec 26, 2013 at 06:12:25PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Dec 26, 2013 at 05:58:09PM +0200, Marcel Apfelbaum wrote: > > > > > On Thu, 2013-12-26 at 17:41 +0200, Michael S. Tsirkin wrote: > > > > > > On Thu, Dec 26, 2013 at 04:09:58PM +0200, Marcel Apfelbaum wrote: > > > > > > > On Thu, 2013-12-26 at 15:53 +0200, Michael S. Tsirkin wrote: > > > > > > > > On Thu, Dec 26, 2013 at 03:24:28PM +0200, Marcel Apfelbaum wrote: > > > > > > > > > On Thu, 2013-12-26 at 14:46 +0200, Michael S. Tsirkin wrote: > > > > > > > > > > On Thu, Dec 26, 2013 at 02:19:48PM +0200, Marcel Apfelbaum wrote: > > > > > > > > > > > Acpi unit-test will fail every time the acpi tables change. > > > > > > > > > > > > > > > > > > > > > > The series adds a script that rebuilds the expected aml files, so the test > > > > > > > > > > > will pass. It also validates the modifications. > > > > > > > > > > > > > > > > > > > > > > The acpi unit test will rebuild the aml tables if TEST_ACPI_REBUILD_AML > > > > > > > > > > > environment variable is set. > > > > > > > > > > > > > > > > > > > > OK I had to fix some trailing whitespace, otherwise > > > > > > > > > > looks good. > > > > > > > > > > I applied it all, pls check the pci branch. > > > > > > > > > Thanks! > > > > > > > > > I pulled the pci branch, but I did not see the patches yet. > > > > > > > > > I used git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git, > > > > > > > > > pci branch. > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > Marcel > > > > > > > > > > > > > > > > > > > > > > > > Actually had to revert. Build fails with recent gcc: > > > > > > > Strange, I update the gcc to the Fedora's latest 4.8.2 and > > > > > > > it still doesn't happen. > > > > > > > Anyway, I use qemu_write_full as advised and resent. > > > > > > > > > > > > > > Thanks, > > > > > > > Marcel > > > > > > > > > > > > OK I applied this for now but I see an issue: iasl crashes below. > > > > > Thanks! > > > > > By the way, I resend the whole series, I hope you used it. > > > > > > > > yes pushed, take a look > > > > > > > > > > I think this happens when we run it on a file > > > > > > it does not understand. > > > > > > It's an iasl bug but would be nice to work around > > > > > > it in some way (and it would be nice to report to > > > > > > robert moore) > > > > > > > > > > I cannot reproduce it, I'll try anyway. > > > > > By the way, the test checks if iasl exits with error, > > > > > so it should handle this gracefully. (I hope!) > > > > > > > > > > Regarding the IASL project, I'll see if I can open a bug, > > > > > > > > no, just send mail. > > > > > > > > > (if I can reproduce it, otherwise I risk they'll ask some > > > > > questions I cannot answer...) > > > > > > > > > > Thanks, > > > > > Marcel > > > > > > > > This is on fedora 19, 32 bit. > > > > > > I see that the issue is with HPET table. > > > > > > iasl -e DSDT -e SSDT -d HPET > > > > > > crashes for me > > > > > > iasl -d HPET > > > > > > does not crash > > > > > > I think that only DSDT and SSDT need -e. > > > > > > Just skip -e for anything that is not an SSDT > > > and not a DSDT. > > Thanks for the tip. I'll send a fix soon. > > Marcel > > > > > > > > > > > also I see you still do > > aml_file = g_strdup_printf("%s/%s/%.4s", data_dir, > data->machine, > (gchar *)&sdt->header.signature); > > > this will not work if we have > 1 SSDT. As I stated in a prev thread: >>From what I understand there is only one ssdt table named SSDT, all others are named differently: "APIC" "HPET". I think multiple SSDTS have different signatures, even in my laptop they are called: SSDT1, SSDT2, SSDT3,... So, even if the SPEC allows it, for qemu we can use different signatures for ssdt tables (it is allowed). (otherwise it will complicate the code unnecessary) Thanks, Marcel >