qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel.a@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH resend 0/7] acpi unit-test: new features
Date: Sun, 29 Dec 2013 11:52:54 +0200	[thread overview]
Message-ID: <1388310774.21013.2.camel@localhost.localdomain> (raw)
In-Reply-To: <87r48yy55o.fsf@linaro.org>

On Fri, 2013-12-27 at 10:11 +0000, Alex Bennée wrote:
> marcel.a@redhat.com writes:
> 
> > This resend includes the following:
> >
> > Compare resulting aml vs expected aml:
> >  - runs only if iasl is installed on the host machine.
> <snip>
> >
> >  configure                                    |   4 +
> >  scripts/create_config                        |   4 +
> snip>
> 
Hi Alex,
Thank you for your review,

> Did I miss something? How does this ensure the test runs when "make
> test" is executed?

It does not, It only ensures that iasl path is exported to the code.
The test itself runs like all the other tests.

Thanks,
Marcel

> 
> 
> Cheers,
> 
> --
> Alex Bennée
> QEMU/KVM Hacker for Linaro

      reply	other threads:[~2013-12-29  9:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-26 14:54 [Qemu-devel] [PATCH resend 0/7] acpi unit-test: new features Marcel Apfelbaum
2013-12-26 14:54 ` [Qemu-devel] [PATCH resend 1/7] acpi unit-test: add test files Marcel Apfelbaum
2013-12-26 14:54 ` [Qemu-devel] [PATCH resend 2/7] configure: added acpi unit-test files Marcel Apfelbaum
2013-12-26 14:54 ` [Qemu-devel] [PATCH resend 3/7] acpi unit-test: compare DSDT and SSDT tables against expected values Marcel Apfelbaum
2013-12-26 14:54 ` [Qemu-devel] [PATCH resend 4/7] configure: add CONFIG_IASL to config-host.h Marcel Apfelbaum
2013-12-26 14:54 ` [Qemu-devel] [PATCH resend 5/7] acpi unit-test: extract iasl executable from configuration Marcel Apfelbaum
2013-12-26 14:54 ` [Qemu-devel] [PATCH resend 6/7] acpi unit-test: added script to rebuild the expected aml files Marcel Apfelbaum
2013-12-26 14:54 ` [Qemu-devel] [PATCH resend 7/7] acpi unit-test: hook to rebuild " Marcel Apfelbaum
2013-12-27 10:11 ` [Qemu-devel] [PATCH resend 0/7] acpi unit-test: new features Alex Bennée
2013-12-29  9:52   ` Marcel Apfelbaum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388310774.21013.2.camel@localhost.localdomain \
    --to=marcel.a@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).