From: Hu Tao <hutao@cn.fujitsu.com>
To: qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>
Subject: [Qemu-devel] [PATCH v2] docs/specs/qcow2.txt: fix incorrect bits of offsets in entries
Date: Mon, 30 Dec 2013 16:00:17 +0800 [thread overview]
Message-ID: <1388390417-14381-1-git-send-email-hutao@cn.fujitsu.com> (raw)
Fix incorrect bits of offsets in refcount table entry, l1 table
entry and l2 table entry. See REFT_OFFSET_MASK, L1E_OFFSET_MASK
and L2E_OFFSET_MASK.
Fix a typo while at the file.
Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
---
v2: update comments as well.
docs/specs/qcow2.txt | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
index f19536a..0abf196 100644
--- a/docs/specs/qcow2.txt
+++ b/docs/specs/qcow2.txt
@@ -192,9 +192,9 @@ as follows:
Refcount table entry:
- Bit 0 - 8: Reserved (set to 0)
+ Bit 0 - 7: Reserved (set to 0)
- 9 - 63: Bits 9-63 of the offset into the image file at which the
+ 8 - 63: Bits 8-63 of the offset into the image file at which the
refcount block starts. Must be aligned to a cluster
boundary.
@@ -218,7 +218,7 @@ The L1 table has a variable size (stored in the header) and may use multiple
clusters, however it must be contiguous in the image file. L2 tables are
exactly one cluster in size.
-Given a offset into the virtual disk, the offset into the image file can be
+Given an offset into the virtual disk, the offset into the image file can be
obtained as follows:
l2_entries = (cluster_size / sizeof(uint64_t))
@@ -233,9 +233,9 @@ obtained as follows:
L1 table entry:
- Bit 0 - 8: Reserved (set to 0)
+ Bit 0 - 7: Reserved (set to 0)
- 9 - 55: Bits 9-55 of the offset into the image file at which the L2
+ 8 - 55: Bits 8-55 of the offset into the image file at which the L2
table starts. Must be aligned to a cluster boundary. If the
offset is 0, the L2 table and all clusters described by this
L2 table are unallocated.
@@ -268,9 +268,9 @@ Standard Cluster Descriptor:
With version 2, this is always 0.
- 1 - 8: Reserved (set to 0)
+ 1 - 7: Reserved (set to 0)
- 9 - 55: Bits 9-55 of host cluster offset. Must be aligned to a
+ 8 - 55: Bits 8-55 of host cluster offset. Must be aligned to a
cluster boundary. If the offset is 0, the cluster is
unallocated.
--
1.7.11.7
next reply other threads:[~2013-12-30 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 8:00 Hu Tao [this message]
2014-01-17 7:40 ` [Qemu-devel] [PATCH v2] docs/specs/qcow2.txt: fix incorrect bits of offsets in entries Stefan Hajnoczi
2014-01-20 9:10 ` Kevin Wolf
2014-01-21 2:56 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388390417-14381-1-git-send-email-hutao@cn.fujitsu.com \
--to=hutao@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).